Reject token issuance for edge sites and update tests (#2482)#2484
Merged
evanwang9x merged 3 commits intoJun 11, 2026
Conversation
evanwang9x
force-pushed
the
Evan/Reject-Edge-Tokens
branch
from
4311692 to
c84db04
Compare
evanwang9x
requested review from
Copilot and
nluaces
and removed request for
nluaces
Contributor
|
Nice work. The tokens.go fix looks good. The issue also mentions that skupper token issue can still succeed on edge sites, can we address that path too so issuance is rejected end-to-end, not only at redeem time? Add an edge-site check in token_issue.go ValidateInput so the CLI fails early, not only at redeem time |
Member
|
@evanwang9x I agree with @AryanP123. It works, but it would be nice to improve on the handling of the AccessGrant by the controller as well, to prevent it from changing to a Ready state. |
Contributor
|
LGTM. @fgiorgetti wdyt? |
fgiorgetti
approved these changes
Jun 10, 2026
fgiorgetti
left a comment
fgiorgetti
left a comment
Member
There was a problem hiding this comment.
Looks good to me now! Thank you @evanwang9x !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (#2482)