add system sites e2e tests#2429
Open
nluaces wants to merge 10 commits into
Open
Conversation
fgiorgetti
reviewed
May 8, 2026
fgiorgetti
left a comment
fgiorgetti
left a comment
Member
There was a problem hiding this comment.
It is working fine. I have added a couple of comments related to the image option for some of the module invocations, but I believe we should raise a separate issue to handle that, as it seems to affect all e2e tests.
…release build as well.
fgiorgetti
reviewed
Jun 1, 2026
fgiorgetti
reviewed
Jun 9, 2026
| name: Running E2E Tests | ||
| command: | | ||
| set -x | ||
| export SKUPPER_SYSTEM_CONTROLLER_IMAGE="quay.io/skupper/cli:<< parameters.image_tag >>" |
Member
There was a problem hiding this comment.
Env var is correct, but the image is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e tests that implement the Hello World example in system sites (with manual reload).