Repository navigation
Redesign examples/ and templates/ into one benchmarks/ directory - #959
Merged
Merged
Conversation
Contributor
|
❌ Automatic Labeling Failed An error occurred while trying to automatically label this pull request. Please check the workflow logs for details and add labels manually. |
Pure file moves (git mv), no content changes yet. One directory per
benchmark under benchmarks/<name>/{template,examples/<variant>}, plus
benchmarks/_scaffold/ (generic project/skill scaffolds) and
benchmarks/_shared/ (model_config.py). Path references throughout the
repo are fixed up in the next commit.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Osher Elhadad <Osher.Elhadad@ibm.com>
Rewrites all code, CI workflows, shell scripts, tests, docs, and site
HTML that referenced the old templates/adapters/<x> or examples/<x>
layout to the new benchmarks/<name>/{template,examples/<variant>}
paths. Also fixes relative-path depth in shell scripts and markdown
links that changed since the moved dirs are 2 levels deeper, and adds
benchmarks/README.md (index) and benchmarks/ADDING_A_BENCHMARK.md.
Verified: core test suite (2857/2858 passing; the one failure is
pre-existing on main, unrelated to this change), lychee --offline
link check (0 errors), zero-API toy run, cap-evolve init, intake
skill scaffold, all 5 algorithms via ci/e2e_all_algorithms.sh, and
skills/_registry/lint_skills.py.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Osher Elhadad <Osher.Elhadad@ibm.com>
OsherElhadad
force-pushed
the
refactor/benchmarks-dir
branch
from
November 8, 2026 21:03
97b468f to
cba254b
Compare
A cleanup regex pass in the previous commit over-matched and stripped leading whitespace on 6 unrelated JS comment lines inside dashboard.py's embedded dashboard template (lines ~3467-4272) that don't contain any templates/examples path. Cosmetic only (JS comments inside a Python string literal), but also happened to touch the exact lines GitHub's code-scanning PR check re-flags pre-existing alerts on (py/path-injection, py/polynomial-redos in dashboard.py/harness.py, all already present on main at the same line numbers), so minimizing the diff here avoids a false "new alert" on unrelated lines in this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Osher Elhadad <Osher.Elhadad@ibm.com>
OsherElhadad
pushed a commit
that referenced
this pull request
Nov 8, 2026
Signed-off-by: Osher Elhadad <Osher.Elhadad@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Benchmark material was split across
templates/adapters/<x>(minimal copy-and-runadapters) and
examples/<x>(full worked runs), with inconsistent naming(
tau2_benchvstau2_airlinevstau2_sierra_airline) and no single place to seewhat exists for a given benchmark.
This PR puts everything under one
benchmarks/directory, one folder perbenchmark, each with a predictable
template/and/orexamples/<variant>/shape:templates/andexamples/are removed. Every reference to the old paths —CLI (
cap-evolve init), CI workflows, shell scripts, tests, docs, and the publicsite HTML — is updated to the new layout, with history preserved via
git mv.Checklist
python -m pytest core/tests -qpasses (2857/2858; the one failure —test_explicit_pool_split.py::test_explicit_feedback_and_confirm_become_the_partition— reproduces identically on unmodified
origin/main, so it predates this changeand is unrelated to it)
python skills/_registry/build_manifest.py skillsis cleanpython skills/_registry/lint_skills.py skillsis cleanlychee --offlinelink check over README/docs/benchmarks markdown: 0 errorsbash benchmarks/toy/examples/calc/run.sh,cap-evolve init,intake skill scaffold, and
ci/e2e_all_algorithms.sh(all 5 algorithms) all passcore/tests/test_ci_tau2_sierra_arms.py's example-not-template invariant kept,just re-pointed at the new paths
🤖 Generated with Claude Code