Repository navigation
Bump version to 1.7.0 and test parser updates - #25
Merged
Merged
Conversation
IpLookup swallows reader errors, so an empty or corrupt mmdb passed every suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
shard.ymland the OpenAPIinfo.versionindocs/openapi.yamlmove from 1.6.0 to 1.7.0, ahead of the 1.7.0 release. The 1.6.1 and 1.6.2 tags were cut with both still at 1.6.0, so this also brings them back in line with the released version. No other tracked file states the app version.The Update Parsers workflow now builds the app and runs
crystal specandcrystal spec e2eright after downloading the new user-agent regexes and GeoLite2 database, so a broken download fails the run instead of opening a PR. Its PRs never got tested before: every Run tests run onautomated/update-parsersended asaction_required, waiting for approval. A newspec/lib/parsers_spec.crmakes those tests meaningful for the data: it resolves8.8.8.8and2001:4860:4860::8888toUSand parses Chrome, iPhone Safari, Android Chrome, and Googlebot user agents. Before it,IpLookupswallowed reader errors, so an empty GeoLite2 file passed every suite.Merge timing
Merging redeploys the API docs (
deploy-docs.ymlwatchesdocs/openapi.yaml) and republishessjdonado/bit:latest(publish.ymlruns on every push to master). Merge right before creating the 1.7.0 release so the docs and the release show the same version.Checks
shards checkpasses andshard.lockis unchangeddocs/openapi.yamlparses withinfo.version1.7.0ENV=production shards build --release --no-debug,ENV=test crystal specwith 63 passing examples, andENV=test crystal spec e2e./cli --update-parsersdownloaded fresh data, the build, specs, and e2e passed, andgit status --porcelainlisted onlydata/GeoLite2-Country.mmdb, so no test artifacts reach the bot PRGeoLite2-Country.mmdband an empty regex list, both new parser specs failRejected review findings
shard.yml: useful, but outside a version bump. Worth a separate change if the drift repeats../cli --update-parsersexit non-zero when a download fails: an empty or partial file now fails the new parser specs, so the PR step never runs.