Skip to content

feat(profiles): add feature info field format columns #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjlopez merged 7 commits into from
Sep 30, 2026
Merged

feat(profiles): add feature info field format columns #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d62b94
feat(profiles): add feature info field format columns
fjlopez Sep 27, 2026
17a9715
feat(profiles): seed Menorca GetFeatureInfo field lists
fjlopez Sep 27, 2026
249d0ef
feat(profiles): seed GetFeatureInfo fields on Camí de Cavalls
fjlopez Sep 27, 2026
e6c6b81
fix(profiles): load the Camí de Cavalls field seed
fjlopez Sep 27, 2026
af0610b
feat(profiles): store feature info options in one column
fjlopez Sep 29, 2026
2910f43
test(e2e): cover empty and partial GetFeatureInfo field lists
fjlopez Sep 30, 2026
2b7d2ec
ci: run Actions on Node 24
fjlopez Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@ jobs:
timeout-minutes: 45
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
submodules: recursive

- name: Set up Java 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: '17'
cache: gradle

- name: Set up Node 20
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '20'
cache: npm
Expand All @@ -47,7 +47,7 @@ jobs:

- name: Upload Playwright artifacts
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: playwright-admin-artifacts
path: |
Expand All @@ -60,19 +60,19 @@ jobs:
timeout-minutes: 45
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
submodules: recursive

- name: Set up Java 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: '17'
cache: gradle

- name: Set up Node 20
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '20'
cache: npm
Expand All @@ -97,7 +97,7 @@ jobs:

- name: Upload Playwright artifacts
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: playwright-viewer-artifacts
path: |
Expand All @@ -110,19 +110,19 @@ jobs:
timeout-minutes: 45
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
submodules: recursive

- name: Set up Java 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: '17'
cache: gradle

- name: Set up Node 20
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '20'
cache: npm
Expand Down Expand Up @@ -152,7 +152,7 @@ jobs:

- name: Upload Playwright artifacts
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: playwright-application-contact-artifacts
path: |
Expand All @@ -165,19 +165,19 @@ jobs:
timeout-minutes: 60
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
submodules: recursive

- name: Set up Java 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: '17'
cache: gradle

- name: Set up Node 20
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '20'
cache: npm
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:

- name: Upload Playwright artifacts
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: playwright-mia-cross-artifacts
path: |
Expand All @@ -220,19 +220,19 @@ jobs:
timeout-minutes: 60
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
submodules: recursive

- name: Set up Java 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: '17'
cache: gradle

- name: Set up Node 20
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '20'
cache: npm
Expand All @@ -251,7 +251,7 @@ jobs:

- name: Upload Playwright artifacts
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: playwright-mobile-web-artifacts
path: |
Expand All @@ -264,19 +264,19 @@ jobs:
timeout-minutes: 120
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
submodules: recursive

- name: Set up Java 17
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: '17'
cache: gradle

- name: Set up Node 20
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '20'
cache: npm
Expand Down Expand Up @@ -322,7 +322,7 @@ jobs:

- name: Upload Android E2E artifacts
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: mobile-android-artifacts
path: test-results/mobile-android/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/liquibase-immutability.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ jobs:
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0
submodules: recursive

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/liquibase-seed-identity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ jobs:
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/liquibase-upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Extracted-tree helper unit tests
run: python3 tools/tests/test_prepare_extracted_liquibase.py
Expand All @@ -34,7 +34,7 @@ jobs:
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0
fetch-tags: true
Expand All @@ -56,7 +56,7 @@ jobs:
source: ['1.2.8']
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0
fetch-tags: true
Expand All @@ -72,7 +72,7 @@ jobs:
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand All @@ -88,7 +88,7 @@ jobs:
source: ['1.2.6', '1.2.7', '1.2.8']
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0
fetch-tags: true
Expand All @@ -107,7 +107,7 @@ jobs:
timeout-minutes: 60
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0
fetch-tags: true
Expand All @@ -125,7 +125,7 @@ jobs:
timeout-minutes: 40
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0
fetch-tags: true
Expand Down
19 changes: 19 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,25 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),

## [Unreleased]

### Added

#### Backend Core

- **Profile**: Client profile layers publish ordered `featureInfoFields` for `INFO` cartography parameters. The list is omitted when empty. Labels come from `STM_TRANSLATION` on `CartographyParameter.value` ([sitmun-backend-core#268](https://github.com/sitmun/sitmun-backend-core/pull/268), [#77](https://github.com/sitmun/sitmun-application-stack/issues/77)).

#### Admin Application

- **Layers**: The feature-information field grid is on the cartography form without the experimental query-layer flag. Labels translate per parameter. `N` and `P` edit fraction digits and padding. `F` chooses date or date and time. A WFS DescribeFeatureType request seeds top-level element names ([sitmun-admin-app#469](https://github.com/sitmun/sitmun-admin-app/pull/469), [#77](https://github.com/sitmun/sitmun-application-stack/issues/77)).

#### Viewer Application

- **Map**: A non-empty field list replaces the full GetFeatureInfo property table, in order, with the translated label. `T`, `N`, `F`, `U`, `P`, and `I` follow the map locale. `AUTO` keeps API-SITNA detection. `feature.data` is not rewritten ([sitmun-viewer-app#179](https://github.com/sitmun/sitmun-viewer-app/pull/179), [#77](https://github.com/sitmun/sitmun-application-stack/issues/77)).

#### Profile-level

- **Liquibase**: PostgreSQL and Oracle changelog 27, and development changelog 74, add `PGI_OPTIONS` and format code `AUTO` ([#77](https://github.com/sitmun/sitmun-application-stack/issues/77)).
- **Liquibase**: Development changelog 75 seeds GetFeatureInfo fields on IDE genèric Menorca cartography 1304, Trams del camí de cavalls (`tu007rts_ccavalls`): route, kind, max easting, and website. Spanish and Catalan labels are translations; English is the stored default ([#77](https://github.com/sitmun/sitmun-application-stack/issues/77)).

### Fixed

#### Stack-level
Expand Down
2 changes: 1 addition & 1 deletion back/backend/sitmun-backend-core
Open in desktop
Submodule sitmun-backend-core updated 18 files
+4 −0 CHANGELOG.md
+1 −0 build.gradle
+92 −0 config/db/changelog/23_feature_info_field_format.yaml
+3 −0 config/db/changelog/db.changelog-master.yaml
+15 −7 src/main/java/org/sitmun/administration/service/extractor/featuretype/SimpleFeatureTypeExtractor.java
+1 −0 src/main/java/org/sitmun/authorization/client/dto/CartographyDto.java
+20 −0 src/main/java/org/sitmun/authorization/client/dto/FeatureInfoFieldDto.java
+38 −0 src/main/java/org/sitmun/authorization/client/mapper/ProfileMapper.java
+13 −1 src/main/java/org/sitmun/domain/cartography/parameter/CartographyParameter.java
+52 −0 src/main/java/org/sitmun/domain/cartography/parameter/FeatureInfoFormatOptions.java
+60 −0 src/main/java/org/sitmun/domain/cartography/parameter/FeatureInfoFormatOptionsConverter.java
+50 −0 ...st/java/org/sitmun/administration/service/extractor/featuretype/SimpleFeatureTypeExtractorDocumentTest.java
+98 −0 src/test/java/org/sitmun/authorization/client/controller/FeatureInfoFieldProfileTest.java
+71 −0 src/test/java/org/sitmun/domain/cartography/parameter/FeatureInfoFormatOptionsConverterTest.java
+1 −1 src/test/java/org/sitmun/infrastructure/persistence/type/codelist/CodeListsTest.java
+3 −0 src/test/resources/db/changelog/db.changelog-h2.yaml
+3 −0 src/test/resources/db/changelog/db.changelog-oracle.yaml
+3 −0 src/test/resources/db/changelog/db.changelog-postgres.yaml
1 change: 1 addition & 0 deletions e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Browser E2E against backend-core on in-memory H2. No Docker Compose.
- Map legend (`viewer-legend`): after loading a stubbed catalog leaf, Capas shows capabilities `LegendURL` imagery and the Legend task shows symbology when the stub denies `DescribeLayer` and fails `/wms` GetLegendGraphic (DiBa/ArcGIS-style #164); setup enables `sitna.legend` task-availability
- No base map (`viewer-basemap`): basemap selector option `sitmun-no-base-map` clears raster basemap to a white viewport while a catalog leaf stays visible (#167); setup enables `sitna.basemapSelector` task-availability
- Print preview (`viewer-print`): 1600×700 window; A4 landscape map becomes 1040×704 and A4 portrait 712×1034 while `tc-ctl-prnmap-printing` is set, then returns to window size ([sitmun-viewer-app#160](https://github.com/sitmun/sitmun-viewer-app/issues/160)); setup enables `sitna.printMap` and drops seed `div: "print"` / external logo
- GetFeatureInfo include list plus more-info (`viewer-gfi-fields`): profile for Toponímia (`34_TOPO_TX`, cartography 6) gets a `sitmun.moreInfo` URL task whose placeholder reads `id`, then three field-list cases. One listed field (`name` → Place) keeps Place and the task row, uses omitted `id` in the link, and hides the `id` header. An empty list keeps the original properties plus the more-info row. Two listed fields where one name misses the feature keep both rows (blank cell for the miss), hide unlisted headers, and still show the more-info link (`e2e/viewer/gfi-field-list.spec.ts`).
- HTML GetFeatureInfo embed (`viewer-gfi`): `e2e/viewer/gfi-html-embed.spec.ts` loads the viewer origin, then nested `iframe`s against the WMS stub. Playwright `frame.url()` is the oracle. `/embed/allow` (no `X-Frame-Options`) commits `http://127.0.0.1:18093/embed/allow`. `/embed/deny` (`X-Frame-Options: DENY`) does not. Same-origin `location.href` is not used. Chromium opaque error documents can throw `SecurityError` for both outcomes. Jest covers hide/load/probe ([sitmun-viewer-app#169](https://github.com/sitmun/sitmun-viewer-app/issues/169)).
- More Info Advanced (`viewer-mia`): profile includes `sitna.moreInfoAdvanced` + type-16 parent on Toponímia (seed parent 42 includes query child 38); synthetic FeatureInfo `responseCallback` opens `.sitmun-mia-popup-overlay` and `POST /api/tasks/template/more-info-advanced/render` carries `appId`/`terId` body plus `lang` query ([sitmun-viewer-app#162](https://github.com/sitmun/sitmun-viewer-app/pull/162)); also asserts live backend render, overlay error on 500, close, multi-feature GFI re-render (`selectMiaGfiFeature`), and deferred-route races (late first identify must not overwrite a newer one; close-during-load ignores late fulfill); setup enables MIA + featureInfo task-availability. Shared helpers live in `e2e/viewer/helpers/mia.ts`.
- Local Basic-auth upstream stub (plus unauthenticated `/legend` PNG for #164); capabilities advertise `GetFeatureInfo` `application/json` so SITNA sets `INFO_FORMAT`; GetFeatureInfo for layer `34_TOPO_TX` returns JSON FeatureCollection (XML fixture fallback). Production Liquibase is not modified.
Expand Down
Loading
Loading