Drop the serve dev dependency - #2564
Merged
Merged
Conversation
The test pages only need a static file server for local runs and CI, and the test suite already has one built on serve-handler. Pulling in the serve CLI on top of that added about 90 packages to every contributor and CI install for a single npm script. Reusing the existing test server keeps the same port and directory, so the workflow steps that start it are unchanged. Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com Change-Id: I1fbdf75165fe6470beb6be298735fffc18b6afa5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test pages only need a static file server for local runs and CI, and the test suite already has one built on serve-handler. Pulling in the serve CLI on top of that added about 90 packages to every contributor and CI install for a single npm script.
Reusing the existing test server keeps the same port and directory, so the workflow steps that start it are unchanged.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com
Change-Id: I1fbdf75165fe6470beb6be298735fffc18b6afa5