Make an exported template a website rather than a deck - #373
Merged
Conversation
Exported a template through the real button, unzipped it and served it. Two things a visitor meets immediately were missing. The one button on the page did nothing. Every template's call to action is an in-page link - #start, #signup, #book, sixteen distinct anchors across twenty-one templates - and the exported page emitted no section ids at all, so none of them resolved. Sections now carry section-1, section-2 and so on, and the five templates that open with a button point it at their closing section: clicking it scrolls, verified at 0 to 3400px. A closing call to action has no in-page destination, because only the owner knows whether it should open a signup page, a booking form or their inbox. That one is no longer shipped silently dead: the export names it - "One button needs a real link: Get it free" - and the ZIP's README says how to set it, including mailto: and tel:. There was also no footer of any kind, so a finished site ended mid-scroll with nothing identifying its owner. It now closes with the site's name, its description where there is one, and a copyright line, styled from the theme's own tokens. Three pieces of template copy asserted things the owner had never said: "Trusted by 4,200 teams", "SOC 2 Type II, 99.99% uptime", "4.9 stars, 2.1M downloads". Replaced with claims about the product rather than its traction. Lighthouse on the served export is unchanged at 100 for performance, accessibility, best practices and SEO on both mobile and desktop. Suite 363 passed; all eleven new tests fail on main.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You said the sites we hand people aren't proper. I exported one through the real button, unzipped it, served it and looked. Two things a visitor meets immediately were missing.
The one button on the page did nothing
Every template's call to action is an in-page link —
#start,#signup,#book, sixteen distinct anchors across twenty-one templates. The exported page emitted no section ids at all:Sections now carry
section-1,section-2, … and the five templates that open with a button point it at their closing section. Verified by clicking it on the served export:The closing button is the owner's to fill in
A closing CTA has no in-page destination — only the owner knows whether it opens a signup page, a booking form or their inbox. So it is no longer shipped silently dead. The export names it:
And the ZIP's README gained a section on setting it, covering
https://,mailto:andtel:, plus how#section-Nworks. For tripvault the warning correctly reports one button, not two, because the opening one now resolves.There was no footer
A finished site ended mid-scroll with nothing identifying its owner. It now closes with the site name, its description where there is one, and a copyright line — styled from
--sc-ground,--sc-ink,--sc-mutedand--sc-font-display, so it inherits the site's own look rather than a pasted-on one. Measured on the served page: 165px tall, correct ground colour, hairline border,© 2026 TripVault. All rights reserved.Three claims the owner never made
A template's copy ships as the owner's own words, so it should describe the product, not invent traction. A test now scans all 21 for customer counts, star ratings and compliance certifications.
Unchanged
Lighthouse on the served export: 100 / 100 / 100 / 100 on mobile and desktop, LCP 1.3s mobile and 0.2s desktop — same as before the footer.
Eleven new tests, all failing on
main. Suite 363 passed.Still thin
Templates average 3.7 content sections and zero images. That is a content problem rather than a broken one, and a bigger piece of work — say the word and I will take it next.