Changed BASE_URL for API calls to reflect working URL and upgraded - #14
Open
iamnutzy1975 wants to merge 13 commits into
Open
Changed BASE_URL for API calls to reflect working URL and upgraded#14iamnutzy1975 wants to merge 13 commits into
iamnutzy1975 wants to merge 13 commits into
Conversation
Author
|
Is someone planning to review this? |
added 9 commits
April 11, 2023 14:32
|
Like the update, but probably worth a few changes. Left comments. |
andrewelkins
suggested changes
Apr 13, 2023
andrewelkins
left a comment
There was a problem hiding this comment.
Remove the .idea/* files.
Keep the setup file with singer-io
| description='Singer.io tap for extracting currency exchange rate data from the exchangeratesapi.io API', | ||
| author='Stitch', | ||
| url='http://github.com/singer-io/tap-exchangeratesapi', | ||
| url='http://github.com/adswerve/tap-exchangeratesapi', |
There was a problem hiding this comment.
Probably worth reverting this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Updated base_url variable which is used in all http requests. The previous one no longer worked.
Manual QA steps
NOTE: Any historical date larger than Y2K works in the above examples
Risks
Rollback steps