Fix infinite loop in ASF parser on malformed input (v16 backport) - #792
Closed
mhassan1 wants to merge 1 commit into
Closed
Fix infinite loop in ASF parser on malformed input (v16 backport)#792mhassan1 wants to merge 1 commit into
mhassan1 wants to merge 1 commit into
Conversation
A crafted ASF file with a zero-size sub-header would cause `tokenizer.ignore()` to move the position backwards, creating an infinite loop that starves the event loop.
Collaborator
|
It does not make sense to update such an old version, just switch to the ESM version. |
Author
That isn't possible for everyone, unfortunately (v16 still has 5m downloads/week, about 15% of the total), but if that's the official stance, we can close this. |
Owner
|
There will always be projects that don't upgrade to any major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports 319abf8 to the
16branch.