Repository navigation
Stop tracking package-lock.json - #4
Merged
Merged
Conversation
tabar is a library: consumers never install from its lock file, and CI should resolve fresh to catch what consumers will get. CI and release now run npm install, with the npm cache keyed on package.json. The visual job was pinned to a Playwright image matching the version in the lock. Without the lock, a new job resolves the version from package.json and the visual job runs in that version's image. @playwright/test narrows from ^1.61.0 to ~1.61.0, still a range, so a minor bump stays a deliberate change that refreshes the screenshot baselines. Verified without the lock: install, lint, typecheck, 147 tests and build pass; Playwright resolves 1.61.1, whose image exists. The visual tests need that container and run first in this pull request's CI. The lock file stays on disk, now ignored.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Contributor instructions now fail without a lock file, and the visual job can install a different Playwright version than its container.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Stops tracking the npm lock file so library CI resolves consumer-visible dependency ranges.
Changes:
- Ignores and removes
package-lock.json. - Uses
npm installwith package-based cache keys. - Dynamically aligns the visual-test container with Playwright’s resolved version.
| File | Description |
|---|---|
.gitignore |
Ignores the npm lock file. |
package-lock.json |
Removes the tracked dependency lock. |
package.json |
Restricts Playwright updates to patch releases. |
.github/workflows/ci.yml |
Adds dynamic Playwright resolution and lock-free installs. |
.github/workflows/release.yml |
Uses lock-free installation during releases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| cache: npm | ||
| - run: npm ci | ||
| cache-dependency-path: package.json | ||
| - run: npm install --no-audit --no-fund |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tabar is a library: consumers never install from its lock file, and CI should resolve fresh to catch what consumers will get. CI and release now run npm install, with the npm cache keyed on package.json.
The visual job was pinned to a Playwright image matching the version in the lock. Without the lock, a new job resolves the version from package.json and the visual job runs in that version's image. @playwright/test narrows from ^1.61.0 to ~1.61.0, still a range, so a minor bump stays a deliberate change that refreshes the screenshot baselines.
Verified without the lock: install, lint, typecheck, 147 tests and build pass; Playwright resolves 1.61.1, whose image exists. The visual tests need that container and run first in this pull request's CI. The lock file stays on disk, now ignored.