Skip to content

Group Dependabot updates; CI hygiene - #12

Merged
imanimanyara merged 2 commits into
mainfrom
ci/dependabot-groups
Oct 12, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
ci/dependabot-groups

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

The failing Dependabot runs on main are all security-update jobs (vitest, happy-dom, esbuild), and each fails with dependency_file_not_supported. The weekly version updates are unaffected. Dependabot cannot raise an npm security fix in a repository that tracks no lockfile, and the org policy is that a library tracks none. So every future alert here will produce failing jobs the same way, whatever dependabot.yml says. This PR fixes what the config can:

  • Dependabot: minor and patch updates grouped per ecosystem (rendered from the agent-kit policy), still on Monday 06:00 America/New_York.
  • CI hygiene: concurrency with cancel-in-progress, draft skip, and timeouts on every job. The Node 18/20/22/24 matrix is unchanged.

Not fixed here, needs an owner decision. The one open alert is #5, GHSA-82fw-gwwq-j7x9 (medium; vitest >=2.1.0 <4.1.11, devDependency). The only patched release is vitest 4.1.11, and vitest 4 requires Node ^20 || ^22 || >=24. That conflicts with the CI matrix's Node 18 leg ("18 is the engines floor; keep it tested while package.json promises it"). The options:

  1. Raise engines.node to >=20 (Node 18 is end-of-life), drop the 18 leg, and bump vitest and @vitest/coverage-v8 to ^4.1.11.
  2. Keep Node 18 and dismiss the alert as dev-only. The advisory concerns vitest's mocker, which is not shipped to consumers.

The repeated security-job failures are a separate decision: turn off "Dependabot security updates" for this repository (alerts stay on), or accept a failed job per alert.

Verified locally: actionlint clean; ci_cost.py --visibility public no findings.

One pull request per ecosystem per week for minor and patch updates, instead of
one per dependency. Rendered from the agent-kit policy; schedule unchanged
(Monday 06:00 America/New_York).
A newer push to the same pull request now cancels the run it supersedes, drafts
do not run until marked ready, and every job has a timeout instead of the
360-minute default. The repository is public, so this is hygiene rather than
spend; the Node 18-24 matrix is unchanged.
Copilot AI balanced review requested due to automatic review settings October 12, 2026 20:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@imanimanyara
imanimanyara merged commit 34d32f0 into main Oct 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants