Repository navigation
Raise esbuild, Vitest and happy-dom past their security advisories - #10
Merged
Merged
Conversation
Every esbuild release below 0.28.1 is covered by an advisory, and ^0.23 stops below 0.24, so Dependabot's security update could not reach the fix and failed on each run. The build, 147 tests, lint and typecheck pass on 0.28.2. Vite 5 inside Vitest 2 still carries esbuild 0.21, which needs the Vitest upgrade.
imanimanyara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot reports four advisories on tabar's dev dependencies, and its security updates had been failing on every run:
^0.23stops below 0.24, so the fix was out of range^0.28.1^3.2.6(+@vitest/coverage-v8)^20.8.9^20.8.9Locally, on esbuild 0.28.2, Vitest 3.2.7 and happy-dom 20.14.5: build, 147 of 147 tests, lint and typecheck pass, and Vite now shares the patched esbuild instead of carrying 0.21. The esbuild commit alone passed all 6 checks.
Caveat: Vite 7, which Vitest 3 resolves to, needs Node 20.19+, and happy-dom 20 needs Node 20+, so the
test (18)leg may no longer be able to run the suite. Node 18 has been end-of-life since April 2025. The library's own runtime floor (engines.node >=18) is unchanged here.