Repository navigation
Rewrite placeholder credentials in tests and docs - #24
Merged
Merged
Conversation
The framework DSN tests now build the expected URL from DbConfig().default_password instead of carrying root:<pw>@ literals, the env reveal and redaction tests use test-secret-not-real, and the Route53 credentials fixture uses example-key. Assertions are unchanged.
Show the AWS credentials file with <your-access-key-id> and <your-secret-access-key>, and the local DSNs with <password>, naming db.default_password (shimkit-dev) once beside each example so no detail is lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the placeholder credentials secret scanners read as real. Two commits:
DbConfig().default_passwordinstead of aroot:shimkit-dev@literal; the env reveal and redaction tests usetest-secret-not-real; the Route53 credentials fixture usesexample-key(nothing validates its shape). Same assertions.<your-access-key-id>/<your-secret-access-key>, and the DSN examples in CHANGELOG and release notes use<password>, with one line namingdb.default_password(shimkit-dev) beside each so no detail is lost.No product behaviour changes: the scaffolders still write
shimkit-dev. No config change: no fixture or example-env paths.Verified locally:
secret_scan.py check --ref HEADexits 0. Gates: ruff check, mypy, pytest with coverage (84.85%, floor 84). 6 tests fail on this macOS host, and the same 6 fail onmain.