Repository navigation
Run CI on pull requests instead of pushes to main - #12
Merged
Merged
Conversation
The org rule is that every change reaches main through a pull request, so CI belongs on pull_request, where it gates the change before it lands. A push trigger on main runs after the change has already landed and re-runs every check a second time when a pull request merges. Drop the push-to-main trigger and make sure workflow_dispatch is present so a maintainer can still re-run the workflow by hand. Existing pull_request filters and any schedule are unchanged; tag-driven release workflows are untouched.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow triggers correctly implement the stated policy without altering existing PR filters or schedules.
Review effort: Balanced
Findings: None
What changed in this PR
Updates CI triggers to align with pull-request-only changes to main.
Changes:
- Removes push-to-
maintriggers. - Adds manual
workflow_dispatchtriggers. - Preserves CodeQL’s weekly schedule.
| File | Description |
|---|---|
.github/workflows/codeql.yml |
Runs CodeQL on PRs, manually, and weekly. |
.github/workflows/ci.yml |
Runs CI on PRs or manual dispatch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts push-to-main CI triggers to pull-request-only CI, per the org rule that changes reach
mainthrough a pull request.push: branches: [main]from the affected workflows.workflow_dispatchis present so a maintainer can re-run by hand.pull_requestfilters andscheduletriggers are unchanged. Tag-driven release workflows are untouched.CodeQL workflows keep their weekly
schedule, which still analyses the default branch.