Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryHigh Risk Overview Tightens Knowledge Base connector sync + tag slot behavior. Enforces billing-based gating for “live” connector sync intervals (<60 min) on create/update, updates the connector UI to expose a new Live sync option (Max-only) with disabled states/badges, and improves tag definition slot assignment by reusing existing slots when display name + field type match. Expands tables UX + export capabilities. Adds CSV export (with filter/sort applied) and export tests, enhances table header menus with sort/filter actions, supports column-scoped filtering via an imperative Analytics/test refactors and small fixes. Adds/adjusts PostHog events across folders/schedules/documents/log filters/search/workflow import-export (and removes a chat “marked read” event), modernizes fetch/drizzle mocks in tests, and fixes Linear connector GraphQL variable types from Reviewed by Cursor Bugbot for commit d1c3a98. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d1c3a98. Configure here.
Greptile SummaryThis PR delivers a large tables module improvement (full CRUD, undo/redo, column selection, copy/paste with auto-column creation, drag-to-reorder, sort/filter from column headers, CSV export), adds a CloudWatch block with 7 tools, introduces live-sync gating for KB connectors behind a Max/Enterprise plan check, fixes embedding billing so platform-key usage is recorded, and resolves Linear connector GraphQL type errors. Key highlights:
Confidence Score: 4/5Generally safe to merge — no data-loss or security regressions found; the P2 findings are defensive improvements and a style violation. Score of 4 reflects three P2 items that should be addressed before merge: the non-barrel re-export violates stated project conventions, the drag-drop guard removal is a mild regression, and the missing AbortSignal is a best-practice gap. None of these block functionality today but the drag-drop issue could produce a silent column-order corruption in an edge case. apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx (drag-drop guard), apps/sim/lib/workflows/operations/import-export.ts (re-export rule), apps/sim/app/workspace/[workspaceId]/tables/[tableId]/hooks/use-export-table.ts (abort signal) Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User clicks Export CSV] --> B[useExportTable.handleExportTable]
B --> C{canExport && !isExporting?}
C -- No --> Z[return]
C -- Yes --> D[setIsExporting true]
D --> E[fetchAllTableRows loop]
E --> F[fetchTableRows offset=0]
F --> G{rows.length < totalCount?}
G -- Yes --> H[fetchTableRows offset+=rows]
H --> G
G -- No / rows empty --> I[buildTableCsv]
I --> J[downloadFile .csv]
J --> K[captureEvent table_exported]
K --> L[setIsExporting false]
subgraph Paste Auto-Column Creation
M[handlePaste async] --> N[e.preventDefault sync]
N --> O{neededExtraCols > 0?}
O -- Yes --> P[addColumnAsyncRef x N sequential]
P --> Q[optimistic local col list]
Q --> R[batch update cells]
O -- No --> R
end
subgraph Undo Stack
S[delete column] --> T[push delete-column action]
T --> U{undo?}
U -- undo --> V[addColumnMutation]
U -- redo --> W[deleteColumnMutation]
end
|
d1c3a98 to
3f937bc
Compare
- Add delete-column undo/redo support - Add undo tracking to RowModal (create/edit/delete) - Fix patchUndoRowId to also patch create-rows actions - Extract actual row position from API response (not -1) - Fix Escape key to preserve cell selection when editing - Remove stray conflict marker from modal.tsx
… greptile comments
be83302 to
aef5b54
Compare

Summary
Type of Change
Testing
Tested manually
Checklist