Skip to content

exclude IN_DELETION volumes from lvol list and /connect APIs#1058

Open
boddumanohar wants to merge 2 commits into
mainfrom
exclude-in-deletion-volumes
Open

exclude IN_DELETION volumes from lvol list and /connect APIs#1058
boddumanohar wants to merge 2 commits into
mainfrom
exclude-in-deletion-volumes

Conversation

@boddumanohar
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@mxsrc mxsrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, we should really add a helper with a default include_deleted=False flag for this. The API needs a query argument for this as well. Neither is urgent though.

@noctarius
Copy link
Copy Markdown
Collaborator

noctarius commented May 23, 2026

We cannot just hide them from the listing. There are tools that need to see them, like the control center. We should have a way to adjust filters. Maybe something like ?status=all or ?status=online,in_deletion

Copy link
Copy Markdown
Collaborator

@noctarius noctarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment in slack!

@boddumanohar
Copy link
Copy Markdown
Member Author

I just realised that this could cause inconsistency during volume create with the same name (as the one in_deletion). And an other issue as Chris mentioned that this could also break API contract. So we need to discuss more deeply around this situation needs to be handled given that lvol delete is an asynchronous operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants