docker: show smp-server init errors#1824
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
Ap4sh
requested review from
epoberezkin,
shumvgolove and
spaced4ndy
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1781
entrypoint-smp-serverwas redirecting both stdout and stderr fromsmp-server init, so Docker init failures could make the container exit without any useful logsThis keeps normal init output quiet while leaving stderr visible in container logs. It also documents the existing
PASSconstraints fromBasicAuthand aligns the interactive init error message with the same ruleTests:
sh -n scripts/docker/entrypoint-smp-servergit diff --checkcabal build exe:smp-server --ghc-options -O0 -j1smp-server initstubsmp-server init --yes --ip 127.0.0.1 --password 'passw@rd'rejects the password on stderr