Repository navigation
fix(stream): retain fallback for invalid queue wait hints - #46
Merged
Merged
Conversation
Owner
|
Merged — thank you! Squash-merged as Verified before merging against current main (v0.6.8): it applied cleanly despite the older base, and the merged tree passes the full suite at 440/440 with lint, typecheck, and build green. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queued
10605response with a finite but oversizedwaitTimecan hide a validretryAfterSecondsfallback. For example,waitTime: 1e300andretryAfterSeconds: 30currently produce an unusable wait duration instead of the available 30-second hint; larger values can overflow toInfinityduring conversion to milliseconds.Validate the converted milliseconds as a positive safe integer before selecting the wait hint. Invalid
waitTimevalues then fall back toretryAfterSeconds, while valid hints keep their existing precedence. Add parser regression cases for1e300,Number.MAX_VALUE, andNumber.MAX_SAFE_INTEGER.Validation:
npm run check,npm run lint,npm test(409 tests), andnpm run buildpass. The model-busy regression suite (37 tests) also passes against the installed Pi 1.4.0-editor-completion.1 SDK with real network access disabled.