Repository navigation
Conversation
emteknetnz
marked this pull request as ready for review
August 28, 2026 01:53
blueo
approved these changes
Aug 28, 2026
blueo
left a comment
blueo
left a comment
There was a problem hiding this comment.
works as described. noting security ones have a different format eg [CVE-xzy] message but that can be done separately.
I'll attempt to use the proper message when merging this one haha 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/934
2x fixes:
A)
There was a commit in the changelog that was
FIX - lorem ipsum- it ended up getting theFIXchopped and displayed as a backtick escaped- lorem ipsuminstead - it displayed in the 'Bugfixes' section.Instead it should still show in the bugfixes section, just not have backticks and display as
lorem ispumwith no backticksB)
Several commits e.g. silverstripe/silverstripe-template-engine@e4f5f4e weren't getting picked up in the changelog because they look to have been squash merged, but still retain the 'Merge pull request' line you get from a regular merge - possible github changed something at their end?
Fix it to fallback to commit message body