Skip to content

DEP Switch to markdown parser to thephpleague/commonmark - #271

Merged
ChloeSartorelli merged 1 commit into
silverstripe:masterfrom
creative-commoners:pulls/master/commonmark
Nov 26, 2025
Merged

ChloeSartorelli merged 1 commit into
silverstripe:masterfrom
creative-commoners:pulls/master/commonmark

Conversation

@emteknetnz

@emteknetnz emteknetnz commented Nov 26, 2025 •

Copy link
Copy Markdown
Member

Issue #270

Note that cow has composer.lock gitignored

Change is covered by unit tests in ChangelogItemTest

Changed line is the only one that uses parses an markdown

I've tried running on a prior release (6.1.0-beta1) it created a changelog correctly, including commits with markdown in them - it correctly surronded commit message with backticks e.g.

  - 2025-06-23 [a7cb1b1](https://github.com/silverstripe/silverstripe-linkfield/commit/a7cb1b12822fbedd87445eef4196b1c5eb5cb93c) `Update docs/en/01_basic_usage.md` (Mojmir Fendek)

@ChloeSartorelli ChloeSartorelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChloeSartorelli
ChloeSartorelli merged commit 918a269 into silverstripe:master Nov 26, 2025
9 checks passed
@ChloeSartorelli
ChloeSartorelli deleted the pulls/master/commonmark branch November 26, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants