Repository navigation
Make session evidence trustworthy and harden privacy and lifecycle - #3
Merged
Merged
Conversation
silverstein
marked this pull request as ready for review
October 12, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor movement and branch selection could credit unspoken lines, while report writes and session shutdown had privacy and race problems. This change ties coverage to speech evidence, creates private reports atomically, makes diagnostic replay opt-in, bounds recording verification, and preserves the live report when a check fails.
The frontend uses the canonical report, shows timer and recording-check states, preserves native keyboard behavior, and contains modal focus. Coverage is labeled as a sentence-level estimate: the percentage counts words in covered lines, not individually matched spoken words. PR CI now checks the core, frontend, process lifecycle, and native macOS compilation.
Validation on Apple silicon macOS:
Real microphone, speech permissions, and capture behavior still need native smoke checks before release. The existing 50% sentence threshold and main-line monotonic recording alignment remain. Critical numeric tokens must match exactly, but that alone does not reject a sentence with an incorrect value if enough other words match. Optional branches are excluded from adherence. See
docs/ENGINEERING-REVIEW.mdfor the remaining evaluation work.Adapted from Astra's supplied patch against
e773588, with a corrected coverage label and local macOS validation.