Conversation
Member
|
one feature per PR please |
dharjeezy
force-pushed
the
no-std-and-proofs
branch
from
September 11, 2026 09:16
90f1796 to
f785d99
Compare
Author
|
Understood, split. This PR is now the no_std change only. The proof generation and multiproof work is held back and will come as its own PR once this lands, so it can be judged separately |
dharjeezy
force-pushed
the
no-std-and-proofs
branch
from
September 11, 2026 09:22
f785d99 to
96b63ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds
no_stdsupport. Nothing else.This previously also added merkle proof and multiproof generation. That is split out per your request and will come as its own PR once this lands, so each can be judged on its own. The diff here drops from 1583 additions to 32.
Why
Substrate runtimes compile to
wasm32-unknown-unknownwithoutstd. Everything this crate needs is incoreandalloc.Changes
#![cfg_attr(not(feature = "std"), no_std)]withextern crate allocstdimports replaced withallocequivalentsstdfeature wires through to the dependencies that need it7 files, 32 insertions, 20 deletions. The
stdbuild is unchanged.Why it cannot build yet
tree_hashdepends onethereum_hashingwith thesha2feature, which #23 adds, and onethereum_sszno_std from #86.Verification
Verified locally against the proposed branches via path patches.
cargo testcargo check --no-default-features --features sha2 --target wasm32-unknown-unknowncargo fmt --checkOne caveat: the
trybuildtest cannot pass under a path patch, since it spawns its own cargo build that does not inherit the patch and resolvesethereum_hashingfrom crates.io. It should pass normally once #23 releases.Where this sits
Proof generation follows separately after this. The branch name is unchanged so the review thread is preserved, and no longer describes the contents.