Skip to content

Delegate VariableList arbitrary impl to Vec<T> #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macladson merged 1 commit into from
Mar 30, 2026
Merged

Delegate VariableList arbitrary impl to Vec<T> #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/variable_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,15 +391,17 @@ where
impl<'a, T: arbitrary::Arbitrary<'a>, N: 'static + Unsigned> arbitrary::Arbitrary<'a>
for VariableList<T, N>
{
/// Delegate to `Vec<T>`'s `Arbitrary` implementation which prevents a single list
/// from being too large.
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
let max_size = N::to_usize();
let size = u.arbitrary_len::<T>()?.min(max_size);
let mut vec: Vec<T> = Vec::with_capacity(size);
for _ in 0..size {
vec.push(<T>::arbitrary(u)?);
}
let mut vec = <Vec<T>>::arbitrary(u)?;
vec.truncate(N::to_usize());
Self::new(vec).map_err(|_| arbitrary::Error::IncorrectFormat)
}

fn size_hint(depth: usize) -> (usize, Option<usize>) {
<Vec<T>>::size_hint(depth)
}
}

#[cfg(test)]
Expand Down
Loading