Gloas gossip handlers by pawanjay176 · Pull Request #9924 · sigp/lighthouse

pawanjay176 · 2026-08-26T19:59:34Z

Issue Addressed

N/A

Proposed Changes

Enable all gloas gossip test handlers. Have intentionally skipped quite a few test vectors where the tests expects us to store invalid blocks or construct a history of invalid blocks.

Must re-enable gas limit tests after #9905
Must re-enable partial data column tests in #9325

Note to reviewer: better to review commit wise.
Used codex assistance for the harness building.

…cal head

mergify · 2026-08-26T20:24:33Z

Some required checks have failed. Could you please take a look @pawanjay176? 🙏

…disparity

pawanjay176 · 2026-08-26T22:28:29Z

        }

        let cached_head = ctx.canonical_head.cached_head();
-        let current_slot = ctx


I'm not completely sure of this. I'd reckon some of the parent gas limit changes would affect this too, so happy to modify this once that's merged

just a note for myself later, but it seems the spec has moved to head-compatible bid validation only, so the bid parent state will always be either the head or its parent.

NikhilSharmaWe · 2026-09-12T15:49:44Z

+                    "failed to mark setup payload for block {block_root:?} as received: {e:?}"
+                ))
+            })?;
+        Ok(())


I think the gas-limit ignores may be covering a harness gap.

GossipVerifiedPayloadBid::new reads parent gas from observed_execution_payloads, but import_setup_payload_for_bid never seeds that cache (only store + fork choice). Bids then hit ParentExecutionPayloadUnknown before the gas-limit check.

The ignore comment still says we use the head state's bid gas limit, which isn't true anymore. Worth seeding the cache here (or reusing the normal import path)?

Yeah fixed this I think. The re-enabled tests work now.

pawanjay176 · 2026-09-15T23:31:12Z

+            "gossip_execution_payload_envelope__ignore_pre_finalized",
+        ];
+        const IGNORED_EXECUTION_PAYLOAD_BID_CASES: &[&str] = &[
+            // Advancing the parent state across an epoch for every gossip bid would put epoch


I'm torn on this one.
To re-enable this test, we need to run epoch processing in gossip which kinda seems unnecessary.
We would still accept the bid if it gets accepted in the block, but ignore it over gossip.

Doing epoch processing in gossip during bad network conditions might be a lot of work, so I have opted for disabling the test and not running epoch processing, but open to change my mind on this.

maybe we could run the tests and assert that we ignore (with no peer penalty?) rather than accept?

I agree that state advance inside bid validation seems pretty sketchy

That would require adding a bit of machinery in the harness to special case this test which kinda seems weird. Our current behaviour is ignore + no penalty. If we start doing this for other tests, then the harness would get gnarly soon imo.

Related, ish?

Fix gossip bid rejection at epoch boundaries and on the head's parent #10061

…#10061) ## Issue Addressed Valid payload bids can be dropped with `EpochOutOfBounds` when the cached head is from the previous epoch. Bids on the head's parent can also be rejected with `InvalidPrevRandao` because validation uses the head's RANDAO mix. ## Proposed Changes Validate `prev_randao` against the bid's beacon parent using the existing `head_random` and `parent_random` helpers. Add a regression for a head in the previous epoch. Head-parent RANDAO spec coverage is tracked in [consensus-specs#5645](ethereum/consensus-specs#5645). ## Additional Info The [Gloas gossip rule](https://github.com/ethereum/consensus-specs/blob/a8475719ce77cb269191e327e1f4175c295851ee/specs/gloas/p2p-interface.md#execution_payload_bid) uses the parent post-state's current epoch. Related to #9924.

mergify · 2026-09-23T06:53:31Z

This pull request has merge conflicts. Could you please resolve them @pawanjay176? 🙏

jimmygchen · 2026-09-25T04:02:12Z

Merged unstable and resolved the conflict, keeping the RANDAO fix from #10061. Also opened pawanjay176/lighthouse#13 against your branch to fix the mock-engine panic in the bid gossip spec tests.

* Fix mock engine panic in bid gossip spec tests * Limit mock fork-choice responses to setup payloads

mergify · 2026-09-28T19:49:19Z

Some required checks have failed. Could you please take a look @pawanjay176? 🙏

pawanjay176 · 2026-09-28T21:11:47Z

This is ready for a re-review. I'm not super particular about getting this for 8.3.0 RC, but the main prod changes are

fix the gossip slot disparity for multiple topics (I think these tests are unnecessary tbh, but might as well pass them)
the block_verification changes that checks that the bid is built on top of parent's full/empty head.

Rest are just test changes.

pawanjay176 added 16 commits August 26, 2026 12:16

Re-enable all gloas gossip tests

6c04524

Add gloas bidparentblockhashmismatch condition

68e021e

Add bid in harness

8f73220

Ignore gloas attestations optimistic conditions in tests

a1ece19

Add proposer preferences tests

1f1bcd0

Gossip execution payload tests

2b83d89

Advance state before processing gossip bid

7eea04b

Add gossip clock disparity for bid

271e92b

Fix harness for gossip bid testcases which require setting the canoni…

7140e6c

…cal head

ptc handlers; adds gossip disparity in prod paths

3bbbfe3

Add data column harness

ab332b5

Remove partial columns stuff

4cd81b3

Fix fake bls harness

4f8a19d

Ignore more tests

5bd1bab

Fix issues after rebase

96f9b44

Organize ignores

2b20891

pawanjay176 requested a review from jxs as a code owner August 26, 2026 19:59

pawanjay176 added test improvement Improve tests ready-for-review The code is ready for review gloas labels Aug 26, 2026

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 26, 2026

pawanjay176 added 2 commits August 26, 2026 13:25

Enable more tests

1fe414f

Fix beacon chain tests that started failing because of adding gossip …

2aadf9e

…disparity

mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 26, 2026

pawanjay176 commented Aug 26, 2026

View reviewed changes

michaelsproul self-requested a review August 26, 2026 23:11

pawanjay176 marked this pull request as draft August 26, 2026 23:42

NikhilSharmaWe reviewed Sep 12, 2026

View reviewed changes

pawanjay176 added 5 commits September 14, 2026 17:34

Merge branch 'unstable' into gloas-gossip-handlers

09b14eb

Fix more gas limit tests

f519175

Use head state epoch instead of wall clock epoch

a80dad9

Re-enable gas limit tests and disable epoch boundary case

9aea561

Merge branch 'unstable' into gloas-gossip-handlers

9ef276b

pawanjay176 force-pushed the gloas-gossip-handlers branch from e3d7738 to 9ef276b Compare September 15, 2026 23:25

pawanjay176 commented Sep 15, 2026

View reviewed changes

Update check

be6f642

pawanjay176 added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 15, 2026

jimmygchen mentioned this pull request Sep 16, 2026

Fix gossip bid rejection at epoch boundaries and on the head's parent #10061

Merged

Merge branch 'unstable' into gloas-gossip-handlers

0efa81a

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 23, 2026

jimmygchen mentioned this pull request Sep 25, 2026

Fix mock engine panic in bid gossip spec tests pawanjay176/lighthouse#13

Merged

Merge unstable into gloas-gossip-handlers

3055f14

Fix beta.2 gossip test setup

de19d68

jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 25, 2026

jimmygchen and others added 2 commits September 25, 2026 23:39

Fix mock engine panic in bid gossip spec tests (#13)

80044ad

* Fix mock engine panic in bid gossip spec tests * Limit mock fork-choice responses to setup payloads

Merge branch 'unstable' into gloas-gossip-handlers

2773173

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 28, 2026

Fix

5889cf7

Navigation Menu

Gloas gossip handlers - #9924

Gloas gossip handlers#9924
pawanjay176 wants to merge 32 commits into
sigp:unstablefrom
pawanjay176:gloas-gossip-handlers

pawanjay176 commented Aug 26, 2026

Uh oh!

mergify Bot commented Aug 26, 2026

Uh oh!

pawanjay176 Aug 26, 2026

Uh oh!

michaelsproul Aug 27, 2026

Uh oh!

NikhilSharmaWe Sep 12, 2026 •

edited

Loading

Uh oh!

pawanjay176 Sep 15, 2026

Uh oh!

pawanjay176 Sep 15, 2026

Uh oh!

michaelsproul Sep 15, 2026

Uh oh!

pawanjay176 Sep 15, 2026

Uh oh!

michaelsproul Sep 16, 2026

Uh oh!

mergify Bot commented Sep 23, 2026

Uh oh!

jimmygchen commented Sep 25, 2026

Uh oh!

mergify Bot commented Sep 28, 2026

Uh oh!

pawanjay176 commented Sep 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pawanjay176 commented Aug 26, 2026

Issue Addressed

Proposed Changes

Uh oh!

mergify Bot commented Aug 26, 2026

Uh oh!

pawanjay176 Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

michaelsproul Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

NikhilSharmaWe Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawanjay176 Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

pawanjay176 Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

michaelsproul Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

pawanjay176 Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

michaelsproul Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Sep 23, 2026

Uh oh!

jimmygchen commented Sep 25, 2026

Uh oh!

mergify Bot commented Sep 28, 2026

Uh oh!

pawanjay176 commented Sep 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NikhilSharmaWe Sep 12, 2026 •

edited

Loading