Notify reprocessing queue after RPC custody column imports - #10128
Merged
mergify[bot] merged 1 commit intoSep 28, 2026
Merged
Conversation
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 32 minutes 23 seconds in the queue, including 29 minutes 57 seconds running CI. Required conditions to merge
|
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
An RPC-fetched payload envelope can complete execution verification while remaining pending on custody columns. When RPC custody columns subsequently complete the import,
process_rpc_custody_columnsrecomputes the head but does not notify the reprocessing queue.As a result, attestations waiting for the payload envelope are not released by this import event and can remain queued until the existing fallback runs.
The same RPC completion branch also handles pre-Gloas block imports.
Proposed Changes
Call the existing
notify_import_after_columnhelper after successful import and head recomputation, using the slot and root returned byAvailabilityProcessingStatus::Imported.This matches the existing gossip column completion paths and emits the appropriate event:
PayloadEnvelopeImportedfor Gloas.BlockImportedfor pre-Gloas.Add regression tests covering deferred envelope import under Gloas and deferred block import under Fulu. The tests check the event type and root, with no additional event in each tested sequence. The Gloas test also checks that no completion event is emitted while the envelope is still awaiting columns.
Additional Info
Both new regression tests failed before the production change and passed afterward:
The existing
release_awaiting_attestations_on_payload_envelope_importedconsumer test also passed. These tests cover the network processor notification and queue consumer separately; they are not a full network E2E test.AI assistance was used for the regression tests, and this PR description.