Skip to content

Notify reprocessing queue after RPC custody column imports - #10128

Merged
mergify[bot] merged 1 commit into
sigp:unstablefrom
0u-Y:fix/gloas-rpc-columns-reprocessing
Sep 28, 2026
Merged

mergify[bot] merged 1 commit into
sigp:unstablefrom
0u-Y:fix/gloas-rpc-columns-reprocessing

Conversation

@0u-Y

@0u-Y 0u-Y commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Issue Addressed

An RPC-fetched payload envelope can complete execution verification while remaining pending on custody columns. When RPC custody columns subsequently complete the import, process_rpc_custody_columns recomputes the head but does not notify the reprocessing queue.

As a result, attestations waiting for the payload envelope are not released by this import event and can remain queued until the existing fallback runs.

The same RPC completion branch also handles pre-Gloas block imports.

Proposed Changes

Call the existing notify_import_after_column helper after successful import and head recomputation, using the slot and root returned by AvailabilityProcessingStatus::Imported.

This matches the existing gossip column completion paths and emits the appropriate event:

  • PayloadEnvelopeImported for Gloas.
  • BlockImported for pre-Gloas.

Add regression tests covering deferred envelope import under Gloas and deferred block import under Fulu. The tests check the event type and root, with no additional event in each tested sequence. The Gloas test also checks that no completion event is emitted while the envelope is still awaiting columns.

Additional Info

Both new regression tests failed before the production change and passed afterward:

FORK_NAME=gloas cargo test --release -p network \
  --features fork_from_env \
  rpc_columns_notify_after_deferred_envelope_import

FORK_NAME=fulu cargo test --release -p network \
  --features fork_from_env \
  rpc_columns_notify_after_deferred_block_import

The existing release_awaiting_attestations_on_payload_envelope_imported consumer test also passed. These tests cover the network processor notification and queue consumer separately; they are not a full network E2E test.

AI assistance was used for the regression tests, and this PR description.

@0u-Y
0u-Y requested a review from jxs as a code owner September 26, 2026 19:10

@pawanjay176 pawanjay176 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mergify

mergify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 32 minutes 23 seconds in the queue, including 29 minutes 57 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Sep 28, 2026
@mergify
mergify Bot merged commit b8c1597 into sigp:unstable Sep 28, 2026
39 checks passed
@mergify mergify Bot removed the queued label Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants