Add sha2 support for non-x86_64 platforms via feature gate. - #18
Merged
Merged
Conversation
Member
|
Hey @koxu1996, sorry for the slow feedback. We like this design, can you please fix the We'll fix the cargo tarpaulin issue. |
Contributor
Author
|
@michaelsproul No worries, formatting fixed. |
Contributor
Author
|
@michaelsproul Any progress with tarpaulin fix? |
Member
|
Ah no, sorry fell off my TODO list. Not sure what's wrong with it |
Member
|
Something with the token settings I think, I'll just merge as-is and fix it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick attempt to allow usage of sha2 on targets like WASM or RISC-V.
This would help fixing sigp/ssz_types#79, because users could just add explicit
ethereum_hashingdependency withsha2feature enabled - then it could be compiled in zkVM.