Repository navigation
Finalize 1.0.0.5 documentation and stabilize the cancellation test - #8
Merged
Merged
Conversation
shurkanTwo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The merged-source Windows run timed out waiting for this test's abort, although the same test passed in the PR run. Other concurrency tests deliberately block pool workers. Avoid putting this bounded-abort check behind that queue; retain the two-second deadline, busy native-start setup and every cancellation assertion. Document the finding in the session review. Production capture code and the 1.0.0.5 version are unchanged.
Evidence
AbortDuringBlockedNativeStartReturnsWithoutCallingNativeCancelat the two-second task wait; the fake camera's abort lock timeout is only 20 ms.After: the abort gets its own worker via the existing
TaskCreationOptions.LongRunningpattern. All 84 local capture/simulator/native-policy tests pass, and the Windows run for the test change passes all 123 tests and packages the plugin. The final merged-source build also passes all 123 tests and packages the verified 1.0.0.5 release.Merge Danger
Door: Two-way
Blast Radius: Tests
Test scheduling and release documentation change. Keep the current documentation focused on the 1.0.0.5 release and its installation instructions. All reviewed runtime fixes remain included in the single combined release.