Repository navigation
Fix busy-start error classification and release credits - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All work from this PR is included in the combined 1.0.0.5 release. Original commits and contributor credits are preserved. Current installation instructions.
Record the final runtime/display corrections at
992f520. Route the expected busy-start rejection through NINA 3.2's recognized exposure-failure path, while retaining capture rejection and prior cancellation. Addresses the known notification mechanism reported in issue #5; physical UI confirmation of the complete report remains outstanding. Original contributor commits and attribution are preserved. The session review records the corrections and hardware limits.Evidence
After: Authored credit text uses @dougforpres, @shurkanTwo, @totoantibes and @christian-photo. Copyright notices and original commits are preserved. The existing production-driver integration test now also checks the failure type and inner cause, while retaining assertions for prior cancellation, one soft-abort warning, no native cancellation and subsequent recovery. Windows tests, release build and packaging passed; the existing 123 tests include the typed failure regression. The merged-source build also passes; the current combined release 1.0.0.5 rebuilds this reviewed work with matching version metadata. Downloaded checksums, package provenance, compiled display metadata, original legal copyright and plugin identity were verified.
Merge Danger
Door: Two-way
The reviewed work is included in the combined release with original contributor commits preserved.
Blast Radius: Exposure
Busy-start error classification, displayed author/contributor descriptions, version and documentation change. NINA's plugin manager still uses the upstream release source; physical-camera validation remains outstanding.