Skip to content

Fix busy-start error classification and release credits - #6

Merged
shurkanTwo merged 2 commits into
masterfrom
maintenance/session-review-1.0.0.7
Oct 17, 2026
Merged

shurkanTwo merged 2 commits into
masterfrom
maintenance/session-review-1.0.0.7

Conversation

@shurkanTwo

@shurkanTwo shurkanTwo commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

All work from this PR is included in the combined 1.0.0.5 release. Original commits and contributor credits are preserved. Current installation instructions.

- busy-start failure becomes generic SonyException and reaches duplicate host notification handlers
+ preserve failure as NINA CameraExposureFailedException with original message/cause
- real names in installed plugin descriptions, contributor display and SOURCE.txt
+ GitHub-handle credits; original legal copyright and commit authorship preserved
- inconsistent README version/status and installation links
+ documentation matches the release classification and installed build

Record the final runtime/display corrections at 992f520. Route the expected busy-start rejection through NINA 3.2's recognized exposure-failure path, while retaining capture rejection and prior cancellation. Addresses the known notification mechanism reported in issue #5; physical UI confirmation of the complete report remains outstanding. Original contributor commits and attribution are preserved. The session review records the corrections and hardware limits.

Evidence

  • Before: Installed AssemblyDescription/LongDescription and packaged SOURCE.txt retained real names despite the handles-only requirement. README version/status disagreed with the published regular release.
    After: Authored credit text uses @dougforpres, @shurkanTwo, @totoantibes and @christian-photo. Copyright notices and original commits are preserved. The existing production-driver integration test now also checks the failure type and inner cause, while retaining assertions for prior cancellation, one soft-abort warning, no native cancellation and subsequent recovery. Windows tests, release build and packaging passed; the existing 123 tests include the typed failure regression. The merged-source build also passes; the current combined release 1.0.0.5 rebuilds this reviewed work with matching version metadata. Downloaded checksums, package provenance, compiled display metadata, original legal copyright and plugin identity were verified.

Merge Danger

Door: Two-way

The reviewed work is included in the combined release with original contributor commits preserved.

Blast Radius: Exposure

Busy-start error classification, displayed author/contributor descriptions, version and documentation change. NINA's plugin manager still uses the upstream release source; physical-camera validation remains outstanding.

@shurkanTwo shurkanTwo changed the title Correct display credits and release documentation for 1.0.0.7 Fix busy-start error classification and release credits for 1.0.0.7 Oct 17, 2026
@shurkanTwo
shurkanTwo merged commit 992f520 into master Oct 17, 2026
1 check passed
@shurkanTwo shurkanTwo changed the title Fix busy-start error classification and release credits for 1.0.0.7 Fix busy-start error classification and release credits Oct 18, 2026
@shurkanTwo
shurkanTwo deleted the maintenance/session-review-1.0.0.7 branch October 18, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant