Repository navigation
Fix capture cancellation, shutter verification and native-error detection - #3
Merged
Merged
Conversation
Preserve aborts through blocked start preflight, verify the nearest learned shutter step, retry unchanged Bulb mode, and stop native access after three qualifying consecutive device errors. Exercise the production native wrappers in portable regression tests and update manual installation and review notes. Restore Robert Hasson's repeated-failure protection from upstream PR dougforpres#13 with restart-only recovery and exclusions for unsupported properties. Co-authored-by: Robert Hasson <robert_hasson@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All work from this PR is included in the combined 1.0.0.5 release. Original commits and contributor credits are preserved. Current installation instructions.
Correct four findings in the initial integration at
413290f; the corrective source is preserved at0341e8f.Retain the original upstream commit history and credits. Restore the repeated-failure guard adapted from @totoantibes's PR dougforpres#13 with restart-only recovery. Update installation instructions and record the corrections in docs/CORRECTIVE-REVIEW.md.
Evidence
After: regression cases with native cancel on/off prevent that start; busy rejection also preserves the preceding capture's cancellation.
After: production-wrapper tests retry until 1/80s, 0.8s and 0.5s respectively, then start once.
After: three qualifying errors hide the camera and block further native calls; unsupported/never-working properties are excluded and success resets the count.
Merge Danger
Door: two-way
Install a backed-up earlier DLL to roll back; no plugin identifier or profile migration changes.
Blast Radius: imaging
Capture cancellation, shutter application and native failure handling affect physical camera/lens operations. Three qualifying consecutive native failures now require restarting NINA and power-cycling the camera; no native cleanup or automatic reconnect follows the guard. Physical camera/USB operation is unverified, and updates are installed manually. The current release includes these corrections and the subsequent session-review fixes.