Repository navigation
feat: add tracing - #274
Open
Patrick Derks (TrayserCassa) wants to merge 1 commit into
Open
Patrick Derks (TrayserCassa) wants to merge 1 commit into
Patrick Derks (TrayserCassa) wants to merge 1 commit into
Conversation
Contributor
Preview helm charthelm upgrade --install shopware-operator \
oci://ghcr.io/shopware/shopware-operator-preview/operator \
--version 0.0.0-add-tracing.ge310ddf
|
Patrick Derks (TrayserCassa)
force-pushed
the
add-tracing
branch
from
October 7, 2026 13:19
04091ad to
f1172ca
Compare
Copilot started reviewing on behalf of
Patrick Derks (TrayserCassa)
October 7, 2026 13:30
View session
Patrick Derks (TrayserCassa)
force-pushed
the
add-tracing
branch
from
October 7, 2026 13:35
f1172ca to
8c2f301
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Jaeger exposes unauthenticated ports beyond localhost, and invalid UTF-8 diagnostics can prevent trace-batch export.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds optional OpenTelemetry tracing across the operator’s reconciliation and Kubernetes operations.
Changes:
- Adds OTLP exporters, span helpers, and tracing tests.
- Instruments controllers, state management, and pod execution.
- Adds Helm configuration, documentation, and local Jaeger support.
| File | Description |
|---|---|
| Makefile | Starts Jaeger for local tracing. |
| internal/tracing/tracing.go | Configures exporters and span helpers. |
| internal/tracing/tracing_test.go | Tests tracing helpers. |
| internal/tracing/kubernetes.go | Instruments Kubernetes HTTP requests. |
| internal/tracing/kubernetes_test.go | Tests request tracing and filtering. |
| internal/manager/status.go | Traces store status updates. |
| internal/manager/queue.go | Traces queue updates and errors. |
| internal/manager/manager.go | Traces state and resource handlers. |
| internal/manager/base/resources.go | Adds resource reconciliation spans. |
| internal/k8s/exec.go | Traces pod execution diagnostics. |
| internal/deployment/queue.go | Traces queue-stat collection. |
| internal/controller/storesnapshot_base_reconciler.go | Traces snapshot reconciliation and status. |
| internal/controller/storeexec_status.go | Records execution status events. |
| internal/controller/storeexec_controller.go | Adds execution reconciliation spans. |
| internal/controller/storedebuginstance_status.go | Records debug-instance status events. |
| internal/controller/storedebuginstance_controller.go | Adds debug-instance reconciliation spans. |
| internal/controller/store_controller.go | Traces store reconciliation and errors. |
| internal/config/config.go | Adds the tracing enable flag. |
| helm/values.yaml | Defines tracing settings. |
| helm/templates/deployment.yaml | Passes tracing environment variables. |
| helm/README.md | Documents tracing configuration. |
| go.sum | Updates dependency checksums. |
| go.mod | Adds tracing dependencies and upgrades. |
| cmd/main.go | Initializes and shuts down tracing. |
| api/v1/storedebuginstance_status.go | Adds latest-condition access. |
| api/v1/execstatus.go | Adds latest-condition access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Patrick Derks (TrayserCassa)
force-pushed
the
add-tracing
branch
from
October 7, 2026 13:39
8c2f301 to
e310ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.