Repository navigation
change predicates - #168
Open
Patrick Derks (TrayserCassa) wants to merge 1 commit into
Open
Patrick Derks (TrayserCassa) wants to merge 1 commit into
Patrick Derks (TrayserCassa) wants to merge 1 commit into
Conversation
Patrick Derks (TrayserCassa)
commented
Jan 28, 2026
Patrick Derks (TrayserCassa)
commented
Contributor
- chore: change the predicate handeling and skip to many updates with deployment
- chore: remove store status for deployments
Patrick Derks (TrayserCassa)
force-pushed
the
change-predicates
branch
from
October 7, 2026 08:29
d146692 to
decc3f0
Compare
Contributor
Preview helm charthelm upgrade --install shopware-operator \
oci://ghcr.io/shopware/shopware-operator-preview/operator \
--version 0.0.0-change-predicates.gbf99130
|
Patrick Derks (TrayserCassa)
requested review from
a team
and
a balanced review from Copilot
October 7, 2026 09:34
Copilot started reviewing on behalf of
Patrick Derks (TrayserCassa)
October 7, 2026 09:34
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The global generation predicate blocks Secret rotations and delays detection of Deployment availability changes.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Replaces custom status filtering with generation-based predicates and simplifies Store status output.
Changes:
- Uses
GenerationChangedPredicateacross Store and snapshot controllers. - Removes the custom status-update predicate implementation.
- Removes deployment readiness columns from Store output.
| File | Description |
|---|---|
internal/controller/storesnapshot_restore_controller.go |
Changes restore event filtering. |
internal/controller/storesnapshot_create_controller.go |
Changes create event filtering. |
internal/controller/store_controller.go |
Changes Store watch filtering. |
internal/controller/predicate.go |
Removes the custom predicate. |
api/v1/store.go |
Removes deployment status columns. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…eployment This will reduce the logs and remove reconciles if the deployment updates the status. This will also lead to not accurate deployment status.
Patrick Derks (TrayserCassa)
force-pushed
the
change-predicates
branch
from
October 7, 2026 11:20
decc3f0 to
bf99130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.