Repository navigation
feat: report invoked tools in project commands - #1650
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughValidation commands now check tool selections before execution. Project fix, format, and validation commands support exclusions and report invocation statuses. Verifier configuration stores multiple extensions, and built-in validation checks each configured extension separately. ChangesVerifier tooling
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant projectValidateCmd
participant selectProjectTools
participant VerifierTools
participant DoCheckReport
projectValidateCmd->>selectProjectTools: Select tools and build invocation statuses
selectProjectTools-->>projectValidateCmd: Return selected tools and statuses
projectValidateCmd->>VerifierTools: Set up tools and run selected checks
VerifierTools-->>projectValidateCmd: Return check results and run error
projectValidateCmd->>DoCheckReport: Report filtered results and invocation statuses
Merge Risk: ⚪ Minimal · up to Tool selections now fail clearly when invalid or empty, and valid selections receive invocation reporting. No identified issue blocks merging after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The changes preserve the inspected selection, exclusion, credential-handling, and Git-review controls. No introduced security exploit was established. Linked extensions can extend the affected filesystem scope, and verbose-output handling and failure recovery remain important operational considerations. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 3 | ❌ 1 | ❓ 1❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation Issue ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ort-invoked-tools-in-project-commands
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
+ Coverage 66.00% 66.03% +0.03%
==========================================
Files 463 464 +1
Lines 31111 31176 +65
==========================================
+ Hits 20534 20587 +53
- Misses 10577 10589 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What changed?
--excludeto project fix and format.builtintool on all (non-ignored) extensions in theproject validatecommand, similar to other tools like PHPStan. Previously the tool was silently skipped as it only worked for a singleextension validatecommand.project/extensioncommands likevalidate+fix+format, which is only visible with--verboseflag.ToolConfig)Why?
Align the project commands with their extension counterparts and make tool selection and execution visible.
How was this tested?
builtinnow works forproject validate.Related issue or discussion
Closes #1502.
Inspired by the extension command changes in #1611 and #1616.
AI disclosure
Part of the change was made by Codex GPT-6.1-Sol
Summary by CodeRabbit
--excludeoption to project fix and format commands, letting you remove tools from the selected set when used with--only.