feat/project upgrade - #1288
Open
Soner (shyim) wants to merge 11 commits into
Open
Conversation
Soner (shyim)
commented
Jul 29, 2026
Soner (shyim)
commented
Member
- fix: cr review
- refactor: remove redundant project details message from overview report
- chore: enable perfsprint linter and apply its fixes
- feat: add admin dev server port detection and update overview model
fmt.Errorf without verbs becomes errors.New, fmt.Sprintf becomes plain concatenation or strconv. Two intentional swallowed errors in the PHP lint walk (reported as validation warnings instead) are annotated for nilerr, which resurfaced alongside the sweep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR5veromwFWWyasWLqv4QJ
…te in Shopware 6.6
…e across multiple files - Updated string concatenation in `mysql.go`, `setup.go`, `tab_overview.go`, `tab_overview_health.go`, `filter_multi_select.go`, `filterlist.go`, `panels.go`, `progress_spinner.go`, `scrollbar.go`, `selectlist.go`, `shortcuts.go`, `textfit.go`, `twocolumn.go`, `overlay_extension_detail.go`, `panel_check.go`, `panel_done.go`, `panel_intro.go`, `panel_prepare.go`, `panel_review.go`, and `panel_run.go` to use separate WriteString calls for better clarity. - Replaced instances of `strings.Repeat` and other calculations with `max` and `min` functions for cleaner logic. - Enhanced readability by breaking down complex lines into simpler, more manageable parts.
normalizeStoreLink matched ":80" as a prefix of custom ports like ":8080", corrupting the URL when trimming; it now parses the URL and only rewrites store.shopware.com links on the default ports. Task.finish mutated the local Task through a pointer receiver inside `return t, t.finish()`, where the copy of t as a return operand races the mutation (unspecified evaluation order). finish is now a value receiver returning the updated Task. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR5veromwFWWyasWLqv4QJ
35 tasks
|
|
||
| sep := lipgloss.NewStyle().Foreground(BorderColor).Render(separator) | ||
| result := s.badge(s.opts.Items[0]) | ||
| var resultSb55 strings.Builder |
Contributor
There was a problem hiding this comment.
What Sb55 stands for?
| envType: envType, | ||
| shopURL: shopURL, | ||
| adminURL: deriveAdminURL(shopURL), | ||
| adminWatchURL: fmt.Sprintf("http://127.0.0.1:%d", extension.AdminDevServerPort(projectRoot)), |
Contributor
There was a problem hiding this comment.
Small thing for when this meets the project proxy branch: in proxy mode the admin watcher isn't on 127.0.0.1:<port> — it's https://admin-watch.<project>.<host> via the shared Traefik (same for storefront). Might be worth having the URL come from a resolver that checks proxy mode first, so we don't have to re-touch the call site on merge — something like:
func resolveAdminWatchURL(projectRoot string) string {
if host := proxyHostname(projectRoot); host != "" {
return "https://admin-watch." + host
}
return fmt.Sprintf("http://127.0.0.1:%d", extension.AdminDevServerPort(projectRoot))
}|
|
||
| func (d *Dumper) generateInsertStatement(cols []string, table string) string { | ||
| s := fmt.Sprintf("INSERT INTO `%s` (", table) | ||
| var sSb592 strings.Builder |
Contributor
There was a problem hiding this comment.
What sSb592 stands for?
| @@ -11,6 +12,49 @@ import ( | |||
| "github.com/shopware/shopware-cli/internal/npm" | |||
| ) | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This is a better source of truth than what I have on the project proxy branch — I derive the admin port purely from the composer version (<6.7 → 8080), which gets it wrong for a 6.6 shop that opted into Vite via ADMIN_VITE. This reads the actual flag, so I'll drop my version and reuse AdminDevServerPort once we merge yours. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.