Repository navigation
Validate Admin SDK dataset selectors against app manifest permissions #1648
Description
Activity
Björn Meyer (@BrocksiNet) This seems better suited to the LSP. Can you file an issue there (would greatly appreciate something far less text-heavy; the team is facing lots and lots of text these days)
Reacted by Björn MeyerThanks somethings (@lasomethingsomething), filed shopware/shopware-lsp#103 for the editor side and shortened this one to the CI part, which should reuse the LSP logic.
Reacted by somethingsso we can close this in favour of the lsp one right?
Reacted by somethingsIf the extension validates, it then uses the LSP internally to throw a warning or an info message, yes. If not, I would say it is good to have it in two places.
Admin SDK
data.subscribe/data.getcalls fail at runtime whenmanifest.xmllacksreadprivileges for the selected entities, and nothing catches this before release.extension validateshould report these missing privileges so CI and Store uploads catch them. The editor-side check lives in shopware/shopware-lsp#103, and this one should reuse its logic instead of reimplementing it.