Skip to content

Deprecate --store-compliance on extension validate #1407

Description

@shyim

TODO

Deprecate --store-compliance on extension validate. Use the config key instead:

validation:
  store_compliance: true

Today three switches set the same field: the flag, SHOPWARE_CLI_STORE_COMPLIANCE=1, and the YAML key. It only gates validateAssets (source vs compiled asset pairing). The flag's "wipe validation.ignore" is broken anyway: the ignores are copied to toolCfg.ValidationIgnores before the wipe. So the flag just duplicates the YAML key.

Work

  1. Mark the flag deprecated and point to validation.store_compliance
  2. Env var: keep it as an override and document it, or deprecate it along with the flag (drop the os.Getenv branch in cmd/extension/extension_validate.go)
  3. Changelog and flag help text
  4. Remove the flag after the deprecation window; keep the config field and the gate

Keep the flag working until then so CI doesn't break.

Out of scope

Activity

  1. lasomethingsomething commented on Aug 26, 2026

    @lasomethingsomething
    Contributor

    Soner (@shyim) Feels like we've discussed this in team chats like we're going to keep it, so let's confirm here that this issue represents our plan. #1462 assumes that we go through with deprecation, and for now I'm operating elsewhere in that way. cc Tomasz Turkowski (@tturkowski) Anne (@Ant1gua) Malte Janz (@MalteJanz))

  2. lasomethingsomething commented on Aug 31, 2026

    @lasomethingsomething
    Contributor

    People should enable in the yaml config vs. pass it via the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or requestgoPull requests that update Go code

Fields

No fields configured for Improvement.

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions