Repository navigation
fix(discovery): allow root UCP profile route - #256
Björn Meyer (BrocksiNet) wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Björn Meyer (@BrocksiNet) Could you actually reproduce the behaviour? Because I couldn't with a setup that is similar to the mentioned one. If you could reproduce, then perhaps something is broken with my environment. But if not, this perhaps is caused by a plugin. If you could reproduce, this fix is not complete. There's no test that fails with the old behaviour and succeeds with the fix. The unit test only shows that it honours an allow-list. The integration test hits the same domain as the sibling test. And the fix itself only covers one route. Every SDK route inherits from the storefront scope ( |
|
Thanks, Dominik Grothaus (@dgrothaus-sw). I rechecked the earlier logs and repeated the trunk checks with the whitelist disabled. Both root and language-prefixed discovery routes return 200 locally, including with five sales-channel domains. The 412 was observed on the reported shop, not reproduced on trunk. Closing this PR because we have not established the cause or a failing regression test, and the profile-only whitelist leaves the API catalog failure unresolved. Issue #251 remains open; we are asking for the exact versions, active plugins, and relevant routing configuration to investigate a possible plugin or configuration interaction. |
Summary
Issue
Closes #251
A request to
/.well-known/ucpon the root storefront domain can be rejected with412 Invalid route scopebefore Shopware resolves the sales-channel domain. The same endpoint works on a localized domain.Validation
GET /.well-known/ucpreturns200 application/json.