fix(checkout): preserve paid transactions from stale cancellations - #798
fix(checkout): preserve paid transactions from stale cancellations#798Daniel Vien (daniel3010) wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee44c4ed61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Fabian Boensch (En0Ma1259)
left a comment
Fabian Boensch (En0Ma1259)
left a comment
There was a problem hiding this comment.
Is it still possible to change the paid state to (partial_)refund?
Ignore late cancel callbacks once a transaction is paid or authorized, and prevent negative PayPal webhooks from demoting paid transactions. Fixes shopware/shopware#19221
5bd1f62 to
10d7de8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10d7de8d2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
2 participants
1. Why is this change necessary?
Late PayPal cancellation callbacks or negative webhooks can change an already paid transaction to
cancelled.2. What does this change do, exactly?
Keep paid transactions unchanged for these inputs, and treat authorized transactions as finalized for browser callbacks. Also load transaction state for v1 webhooks and add regression tests.
3. Describe each step to reproduce the issue or behaviour.
paid.cancel=1, or send a matching negative webhook.cancelled; it now remainspaid.4. Please link to the relevant issues (if any).
5. Checklist