Skip to content

ci(danger): run Danger from composer instead of the latest container image - #236

Merged
Jozsef Damokos (jozsefdamokos) merged 3 commits into
trunkfrom
ci/danger-from-composer
Oct 14, 2026
Merged

Jozsef Damokos (jozsefdamokos) merged 3 commits into
trunkfrom
ci/danger-from-composer

Conversation

@jozsefdamokos

Copy link
Copy Markdown
Member
  • The ghcr.io/shyim/danger-php:latest image was rebuilt for 0.3.14 on a base whose PHP needs a newer glibc than the image ships, so danger ci dies before it starts and every Danger run fails
  • Install Danger from composer as core does: vendor-bin/danger-php/composer.json pins shyim/danger-php to ^0.3.14, the job sets up PHP 8.2, installs that directory and runs vendor-bin/danger-php/vendor/bin/danger ci
  • Declare the token permissions the job needs

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.35%. Comparing base (8dd27d4) to head (adbb73b).

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk     #236   +/-   ##
=========================================
  Coverage     65.35%   65.35%           
  Complexity     4786     4786           
=========================================
  Files           654      654           
  Lines         21753    21753           
=========================================
  Hits          14217    14217           
  Misses         7536     7536           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread vendor-bin/danger-php/composer.json Outdated
Comment thread vendor-bin/danger-php/composer.json Outdated
@vintagesucks Nikolas Evers (vintagesucks) changed the title ci(danger): run Danger from composer instead of the latest container … ci(danger): run Danger from composer instead of the latest container image Oct 14, 2026
@jozsefdamokos
Jozsef Damokos (jozsefdamokos) marked this pull request as ready for review October 14, 2026 09:46
@jozsefdamokos
Jozsef Damokos (jozsefdamokos) merged commit aa885c8 into trunk Oct 14, 2026
13 of 14 checks passed
@jozsefdamokos
Jozsef Damokos (jozsefdamokos) deleted the ci/danger-from-composer branch October 14, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants