Repository navigation
fix: flush migration logs after each process message - #231
Merged
Nikolas Evers (vintagesucks) merged 1 commit intoOct 9, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #231 +/- ##
============================================
- Coverage 65.36% 65.36% -0.01%
Complexity 4786 4786
============================================
Files 654 654
Lines 21756 21758 +2
============================================
+ Hits 14221 14222 +1
- Misses 7535 7536 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Nikolas Evers (vintagesucks)
marked this pull request as ready for review
October 7, 2026 09:46
Nikolas Evers (vintagesucks)
requested review from
a team,
Dennis Garding (DennisGarding),
Pierre02,
Juri Himmelreich (jc-sw-git),
Jozsef Damokos (jozsefdamokos) and
Lars Kemper (larskemper)
October 7, 2026 09:46
Lars Kemper (larskemper)
approved these changes
Oct 7, 2026
Jozsef Damokos (jozsefdamokos)
approved these changes
Oct 7, 2026
Nikolas Evers (vintagesucks)
deleted the
fix/flush-migration-logs-per-message
branch
October 9, 2026 07:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failing nightly 2026-10-07 and #229's merge, with a green nightly in between, all on the same commit
LoggingServicewrites its buffer every 50 entries1, on a service reset, or when the PHP process ends. The admin worker's consume request never resets services2 and keeps polling for up to 20 s3, so a run can finish with its last log entries still in memory (35 and 30 in the two failing runs)MigrationProcessHandlernow flushes after each process message, so every batch's logs are stored before the next one runsFootnotes
https://github.com/shopware/SwagMigrationAssistant/blob/d9ee89e697c03da9d5cc1989384860d36fb12d3f/src/Migration/Logging/LoggingService.php#L102-L103 ↩
https://github.com/shopware/shopware/blob/04ab398d47d25932684a6997db66ce72becb8e7d/src/Core/Framework/MessageQueue/Api/ConsumeMessagesController.php#L67-L81 ↩
20 s time limit per request: https://github.com/shopware/shopware/blob/04ab398d47d25932684a6997db66ce72becb8e7d/src/Core/Framework/MessageQueue/Api/ConsumeMessagesController.php#L69 (default from https://github.com/shopware/shopware/blob/04ab398d47d25932684a6997db66ce72becb8e7d/src/Core/Framework/Resources/config/packages/shopware.yaml#L420), and it only returns early when no message was handled: https://github.com/shopware/shopware/blob/04ab398d47d25932684a6997db66ce72becb8e7d/src/Core/Framework/MessageQueue/Subscriber/EarlyReturnMessagesListener.php#L36-L40 ↩