Skip to content

ci: verify extension against lowest dependencies - #218

Merged
Nikolas Evers (vintagesucks) merged 8 commits into
trunkfrom
ci-verify-lowest
Aug 17, 2026
Merged

Nikolas Evers (vintagesucks) merged 8 commits into
trunkfrom
ci-verify-lowest

Conversation

@vintagesucks

@vintagesucks Nikolas Evers (vintagesucks) commented Aug 14, 2026 •

Copy link
Copy Markdown
Member

follow-up to shopware/SwagMigrationMagento#62

  • AttributeReader::cleanupColumns() used getReferencingColumnNames() and UnqualifiedName (DBAL 4.3+) since fix: phpstan errors #67, so attribute reads through the Shopware local gateway failed on installs whose lockfiles contain an older DBAL
  • the new Extension Verifier (lowest) job uses shopware-cli via shopware/github-actions/extension-verifier to validate the plugin against its lowest resolvable dependencies to catch issues like this in CI in the future
  • shopware/storefront added to suggest, the verifier installs suggested packages and needs them to resolve the theme classes RunService pulls in
  • the two Symfony DI configurator findings ignored in .shopware-extension.yml instead of fixed in code, the only in-code fix would be moving src/DependencyInjection/*.php to src/Resources/config/ which felt too heavy here

example output from the first run of the job:

phpstan.neon
  0  error    [phpstan/error]  Internal error: Class Doctrine\DBAL\Schema\Name\UnqualifiedName was not found while trying to analyse it - discovering symbols is probably not configured properly. while analysing file /tmp/analyse-extension-1320630473/src/Profile/Shopware/Gateway/Local/Reader/AttributeReader.php

✖ 10 problems (5 errors, 5 warnings)

Comment thread .github/workflows/php.yaml Outdated
@vintagesucks
Nikolas Evers (vintagesucks) merged commit ec78bfd into trunk Aug 17, 2026
11 checks passed
@vintagesucks
Nikolas Evers (vintagesucks) deleted the ci-verify-lowest branch August 17, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants