Repository navigation
acp: optionally name new codex sessions so the adapter skips its title thread - #133
Merged
Merged
Conversation
…effect digest Contract Amendment 1: the mint sends `/rename` once, waits at most the bound and publishes the same session whatever the outcome. The unanswered-rename settlement (cancel, hold-back of the first turn) is removed; late output after an unanswered rename is a documented residual. `rename_new_sessions` is now part of the frozen provider-effect digest, encoded only when true so existing identities stay valid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017izEynabPeSUBT573AtvaZ
A bare `cmd = "codex-acp"` on a host entry goes through the packaged wrapper, which resolves the binary on PATH; CI runners have none. Use an absolute path with the same file name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017izEynabPeSUBT573AtvaZ
Owner
Author
|
CI failure on the first push: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a new session's first turn, the
codex-acpadapter starts an ephemeral title-generation thread and never unsubscribes it (upstream issue agentclientprotocol/codex-acp#628, fix PR agentclientprotocol/codex-acp#629, both open). The bridge has no id for that thread, sosession/close(#131) cannot reach it. Its codex-config-level MCP servers (for exampleprism-mcp,node_repl) live until the adapter exits, and each session costs one extragpt-5.6-lunaturn. Measured on adapter 1.13.1 and 2.2.2.Change
rename_new_sessions(defaultfalse). Validation acceptstrueonly whencmdhas the file namecodex-acp./rename <name>once, after mode/model/effort settle and before the session id is published. The adapter answers this locally with no model turn, and an explicitly named session skips title generation.prompt_inner.rename_new_sessionsjoins the frozen provider-effect digest only whentrue, so existing persisted identities keep their digest.README.md,docs/onboarding.md,docs/compatibility.md(accepted limits R1–R5),CHANGELOG.md.Accepted limits (documented)
R1 a wrapper with another file name cannot opt in; R2 tied to the tested adapter versions'
/rename; R3 a never-prompted session is still renamed; R4 on timeout the adapter may still be handling the rename; R5 output from a rename that was not answered within the bound may reach the first turn.Review
acp.session_rename_acknowledged(debug) instead ofacp.session_rename_interrupted(warn). Logging only; the published session and the close contract are unaffected.Verification
cargo fmt --all -- --check, clippy-D warnings, andcargo testforbridge-acp,bridge-core,bridge-container,bridge-registry,bridge-workflowanda2a-bridge. All passed on macOS with 0 failures.PONGagainst the operator serve follows the merge.🤖 Generated with Claude Code
https://claude.ai/code/session_017izEynabPeSUBT573AtvaZ