Repository navigation
feat: Import a whole folder of MIBs at once - #20
Merged
Merged
Conversation
A dropped folder used to arrive as a single unreadable entry in dataTransfer.files, so dropping a MIB directory imported nothing. The drop handler now takes the File System entries of the drop before awaiting anything (the item list is cleared once the handler returns) and walks every directory entry down to its files, subdirectories included. readEntries is called until it returns an empty batch, so a folder with more than the 100 entries Chrome hands back per call is read in full. A "Select folder" button gives the same import through a picker. A folder of MIBs also holds readmes, licenses and archives. Those are not upload failures, so a file that holds no MIB module is counted as skipped in the summary instead of being reported as an error; a real failure is still surfaced as before. Dotfiles and dot-directories are never read. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeKzWHahL8hTUedqLLzx9T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped folder used to arrive as a single unreadable entry in
dataTransfer.files, so dropping a MIB directory imported nothing.
The drop handler now takes the File System entries of the drop before
awaiting anything (the item list is cleared once the handler returns) and
walks every directory entry down to its files, subdirectories included.
readEntries is called until it returns an empty batch, so a folder with
more than the 100 entries Chrome hands back per call is read in full. A
"Select folder" button gives the same import through a picker.
A folder of MIBs also holds readmes, licenses and archives. Those are not
upload failures, so a file that holds no MIB module is counted as skipped
in the summary instead of being reported as an error; a real failure is
still surfaced as before. Dotfiles and dot-directories are never read.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01KeKzWHahL8hTUedqLLzx9T