Repository navigation
Piranha leak guard (keep the private engine out of open source) - #622
Open
markkerzner wants to merge 1 commit into
Open
markkerzner wants to merge 1 commit into
markkerzner wants to merge 1 commit into
Conversation
… open-source repo Piranha (the new paid executor) lives in the private Scaia-ai/piranha repo and plugs into FreeEed via the executor SPI. It must never be committed here. This adds a path-based guard (impl paths org/freeeed/piranha/**, PiranhaProcessor, any piranha/ module, the old FreeEed<->piranha sync scripts, piranha*.jar, FreeEed-Piranha): - scripts/check-no-piranha.sh -- checks a list of files, fails on any offender - .githooks/pre-commit -- runs it on staged adds (enable: git config core.hooksPath .githooks) - .github/workflows/no-piranha.yml -- enforces it on every PR (checks only added/modified files) Path-based, so design docs under docs/ that mention 'piranha' are fine. Checks the diff, so it passes today and blocks future additions (the existing legacy Spark Piranha is removed separately in #3). Claude-Session: https://claude.ai/code/session_01S8Qk89Wtb6ic45qo35JvWS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of keeping the new Piranha engine private (lives in Scaia-ai/piranha, plugs in via the executor SPI). Adds a path-based guard that blocks Piranha implementation + the old sync scripts from entering this public repo:
scripts/check-no-piranha.sh— fails onorg/freeeed/piranha/**,PiranhaProcessor, anypiranha/module,push/pull-freeeed-to-piranha.sh,piranha*.jar,FreeEed-Piranha..githooks/pre-commit— local guard on staged adds (enable:git config core.hooksPath .githooks)..github/workflows/no-piranha.yml— enforced on every PR (checks only the added/modified files).Path‑based (not word‑based), so design docs under
docs/that mention piranha are fine. Checks the diff so it passes today; the existing legacy Spark Piranha is removed separately (#3).https://claude.ai/code/session_01S8Qk89Wtb6ic45qo35JvWS