refactor: graph workspace UI/UX redesign - #10
Merged
Conversation
Capture approved startup precedence, GraphWorkspace architecture, editor section-jump expansion, and filter/controls UX updates for upcoming implementation. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Track the approved catalog UI/UX implementation plan and update the spec header to reflect the renamed working branch.
…x-graph-workspace-design
- Remove redundant viewModel.isGraphMode check inside showDetails (already guarded by outer conditional) - Eliminate optional chaining in details panel by destructuring svc; collapse three IIFEs into one - Fix Operations section visibility: was hidden when links empty even if incident_channel/slo present - Make GraphWorkspace controls div conditional to avoid empty positioned overlay - Remove duplicate handleResetLegendFilters export (kept as resetLegendFilters only) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 141685b09f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Enhance the loading logic to check for and apply any unfinished in-browser draft before fetching from remote sources. - Simplify error handling by removing redundant checks related to stored drafts. - Ensure that the loading state is correctly managed throughout the process.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphWorkspacelayout component — CSS grid with a graph area and an optional side dock for the impact details panel, replacing the old floating full-width overlayaria-pressedstate and a tri-class active/inactive/off pattern; a Reset filters button replaces the legend-embedded hosting toggle, which moves to an overlaid toolbar on the graph canvasRegistryEditorsection-jump config refactored to a typedSECTION_JUMPSarray with anisSectionLabelguard; addshostingandstakeholdersjump entriesTest Plan
npm test -- --run)npm run typecheck)aria-pressedvalue and visual state; Reset filters restores all three filter sets🤖 Generated with Claude Code