[docs] Slurm: fix multi-node example, add single-node and offline batch examples - #36116
Open
holtwood wants to merge 2 commits into
Open
[docs] Slurm: fix multi-node example, add single-node and offline batch examples#36116holtwood wants to merge 2 commits into
holtwood wants to merge 2 commits into
Conversation
holtwood
requested review from
JustinTong0323,
sogalin,
wisclmy0611 and
zijiexia
as code owners
August 23, 2026 23:39
Author
|
/tag-and-rerun-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Contributes to #3244.
The existing multi-node example expands
$SLURM_NODEIDin the batch shell, beforesruncreates its per-task environments. Both launches can therefore receive the same node rank. The existing readiness loop also checks only whether a TCP port is open.This PR covers basic multi-node serving, single-node serving, and offline batch inference. #29991 has a separate scope around PD disaggregation and Apptainer.
Changes
$SLURM_PROCIDinside eachsruntask and use Slurm%npatterns for per-node logs./healthcheck, and early process-exit detection.__main__guard, as required by the Engine multiprocessing setup.Validation
bash -non all three batch scripts.mint validate.mint broken-links.SLURM_PROCID=0andSLURM_PROCID=1.spawnsetup, context-manager support,/healthbehavior, and referenced server arguments against the PR base revision.I did not run these examples end to end on a Slurm GPU cluster. The
#SBATCHresource values, partition name, network interfaces, and port availability remain site-specific.CI States
Latest PR Test (Base): ✅ Run #32676790313
Latest PR Test (Extra): ❌ Run #32676790204
Latest PR Test (AMD ROCm 7.2): ➖ No AMD PR run found for this commit.