Fix canonical YAML options shadowed by deprecated aliases - #36104
Open
gaoxiaomo wants to merge 1 commit into
Open
Fix canonical YAML options shadowed by deprecated aliases#36104gaoxiaomo wants to merge 1 commit into
gaoxiaomo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_StoreActionand_StoreTrueActionoptions available when a deprecated alias shares the samedest;Problem
ConfigArgumentMergercurrently buildsunsupported_actionsone action at atime. A deprecated alias is a custom argparse action and can share its
destination with a supported canonical option. When that happens, the alias
marks the whole destination as unsupported, so a valid YAML option such as
cuda-graph-max-bs-decode: 8raisesUnsupported config option.Support belongs to the complete action set for a destination, not whichever
custom action happens to be registered last. This change first collects the
destinations backed by a standard store action, then excludes those
destinations from
unsupported_actions.The deprecated CLI alias still parses and emits its warning. The change does
not expose the deprecated alias as a new YAML key.
This addresses the YAML parsing regression reported in #29184. It is a narrow
parser fix and does not implement the broader device-graph naming RFC.
Tests
ServerArgscheck: canonical YAML resolved to8; deprecated CLI aliasresolved to
9and retained its deprecation warning;validation,
py_compile, andgit diff --checkpassed.CI States
Latest PR Test (Base): ❌ Run #32658615064
Latest PR Test (Extra): ❌ Run #32658614941
Latest PR Test (AMD ROCm 7.2): ❌ Run #32658615055