[ci] xpu: trigger pr-test-xpu on multimodal_gen changes - #36100
Open
arathi-hlab wants to merge 5 commits into
Open
[ci] xpu: trigger pr-test-xpu on multimodal_gen changes#36100arathi-hlab wants to merge 5 commits into
arathi-hlab wants to merge 5 commits into
Conversation
Drop the !(multimodal_gen) negation from the main_package paths filter so edits under python/sglang/multimodal_gen/ run the XPU stage-A/B suites. The subsystem was previously skipped on XPU because no dedicated multimodal_gen job exists for this backend.
arathi-hlab
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
August 23, 2026 16:37
Collaborator
Author
|
/rerun-failed-ci |
mingfeima
approved these changes
Aug 24, 2026
mingfeima
requested changes
Aug 24, 2026
Match the NPU/MUSA workflow shape: keep !(multimodal_gen) on the main_package paths filter, add a multimodal_gen: paths filter, and add a dedicated multimodal-gen-test-1-gpu-xpu job that runs the diffusion 1-gpu suite via sglang/multimodal_gen/test/run_suite.py. The pr-gate now triggers on either filter, and finish checks the new job's result.
mingfeima
approved these changes
Aug 24, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!(multimodal_gen)negation from themain_packagepaths filter in.github/workflows/pr-test-xpu.yml.python/sglang/multimodal_gen/**will now trigger the XPU stage-A / stage-B test suites, which were previously being skipped.Motivation
Every other backend workflow either routes
multimodal_gento a dedicated job (NPU, MUSA, AMD ROCm) or excludes it entirely (Xeon, MLX, ARM64, XPU). XPU has no dedicatedmultimodal_genjob, so today any PR that only editsmultimodal_gengets zero XPU coverage. This is a divergence from the diffusion team's expectation that XPU exercisesmultimodal_gencode paths as part of the main suite.Diff
Test plan
python/sglang/multimodal_gen/should now schedule the XPU stage-A / stage-B jobs.CI States
Latest PR Test (Base): ✅ Run #32726102628
Latest PR Test (Extra): ❌ Run #32726102229
Latest PR Test (AMD ROCm 7.2): ➖ No AMD PR run found for this commit.