docs: say examples support offline evaluation only - #795
Closed
fuergaosi233 wants to merge 1 commit into
Closed
Conversation
examples/README.md claimed optional configs provide "online/offline evaluation" while the same page and schema reject online eval. Signed-off-by: holegots <fuergaosi@gmail.com>
fuergaosi233
requested review from
FlamingoPg,
shuaills and
sleepcoo
as code owners
September 1, 2026 04:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
examples/README.mdonmaincontradicts itself about online evaluation.Same file, same page:
Supported-looking claim (now fixed):
Contradictory claim (left as-is; matches code):
Code on
main(specforge/config/schema.py) rejects online eval:Tests:
test_online_evaluation_is_explicitly_unsupportedandtest_offline_eval_source_requires_offline_trainingintests/test_config/test_schema.py.Modifications
One wording change in
examples/README.md:online/offline evaluation→offline evaluation.The earlier "Online evaluation is also unsupported." sentence is unchanged.
Related Issues
N/A
Accuracy Test
N/A (docs only)
Benchmark & Profiling
N/A (docs only)
Checklist