Use IN rather than = for queries using arrays - #85
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ActiveCypher’s Relation#where behavior so Model.where(key: ['a', 'b']) generates a Cypher IN comparison (aligning with Rails-style semantics) instead of comparing a property to an array via =.
Changes:
- Update
ActiveCypher::Relation#whereto emitINwhen a hash condition value is anArray. - Add a regression test covering both scalar equality (
=) and array membership (IN) query generation. - Add a commented-out note in
ActiveCypher::Relationship(currently unrelated to the PR’s purpose).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/active_cypher/comparison_arrays_should_in_test.rb | Adds coverage asserting where(name: [...]) renders IN and scalar where(name: ...) renders =. |
| lib/active_cypher/relation.rb | Implements Array values in where(Hash) as IN comparisons. |
| lib/active_cypher/relationship.rb | Adds a commented-out note/code snippet about connects_to_mappings (unrelated to query behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| require 'cyrel' | ||
|
|
||
| module Cyrel | ||
| class ComparisonArraysShouldIn < ActiveSupport::TestCase |
Comment on lines
+9
to
+11
| alice = PersonNode.create(name: 'Alice') | ||
| bob = PersonNode.create(name: 'Bob') | ||
| charlie = PersonNode.create(name: 'Charlie') |
Comment on lines
+23
to
+25
| alice = PersonNode.create(name: 'Alice') | ||
| bob = PersonNode.create(name: 'Bob') | ||
| charlie = PersonNode.create(name: 'Charlie') |
Comment on lines
+32
to
+33
| # Define connects_to_mappings as a class attribute to match ActiveCypher::Base ? | ||
| # class_attribute :connects_to_mappings, default: { reading: :primary, writing: :primary } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match Rails behavior, Model.where(key: ['a', 'b', 'c']) should look for n.key IN ['a', 'b', 'c'] rather than n.key = ['a', 'b', 'c'].