Repository navigation
fix: normalize metasploit session command failure reasons - #14
Merged
Merged
Conversation
Return explicit session command reasons for busy/missing/timeout/error paths and detect meterpreter shell-mode mismatches so callers can react deterministically. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_session_commandfailure reasons to explicit values (session_busy,session_missing,session_object_unavailable,command_timeout,command_error) while preserving existing status valuessession_idin responses and detect Meterpreter shell-mode mismatch fromUnknown commandoutput to returnshell_mode_mismatchwith actionable guidanceTest plan
python3 -m pytest tests/test_session_locking.py tests/test_tools_integration.pypython3 -m pytest tests/test_session_locking.py tests/test_timeout_cap.py tests/test_version_bump.pypoetry buildpython3 -m pytest(currently fails in this environment with numerous pre-existing unrelated test failures)Made with Cursor